Skip to content

Commit

Permalink
adding fb import when no other imports are present (#6030)
Browse files Browse the repository at this point in the history
Co-authored-by: Kamil Rojewski <kamil.rojewski@gmail.com>
Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
  • Loading branch information
3 people committed Jul 30, 2020
1 parent f1025b2 commit f1f23d0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,6 @@ grpc/google/
**/Package.resolved
.clangd/**
package-lock.json
.clwb
/*.ilk
/*.pdb
.clwb
6 changes: 5 additions & 1 deletion src/idl_gen_js_ts.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,15 @@ class JsTsGenerator : public BaseGenerator {
// Emit namespaces in a form that Closure Compiler can optimize
std::string &code = *code_ptr;
std::string &exports = *exports_ptr;

if (lang_.language == IDLOptions::kTs) {
code += "import * as flatbuffers from 'flatbuffers';\n";
}

for (auto it = sorted_namespaces.begin(); it != sorted_namespaces.end();
++it) {
if (lang_.language == IDLOptions::kTs) {
if (it->find('.') == std::string::npos) {
code += "import * as flatbuffers from 'flatbuffers';\n";
break;
}
} else {
Expand Down
1 change: 1 addition & 0 deletions tests/union_vector/union_vector_generated.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// automatically generated by the FlatBuffers compiler, do not modify

import * as flatbuffers from 'flatbuffers';
/**
* @enum {number}
*/
Expand Down

0 comments on commit f1f23d0

Please sign in to comment.