CreateSharedString does not support embedded null bytes [C++, gcc 7.3, macOS, v1.9.0]

[mhfrantz]

The description of FlatBufferBuilder::CreateSharedString includes the phrase "Store a string in the buffer, which can contain any binary data." However, the StringOffsetCompare class uses strncmp instead of memcmp, so it will stop comparing on the first null byte.

[stale]

This issue has been automatically marked as stale because it has not had activity for 6 months. It will be closed if no further activity occurs. Thank you for your contributions.

[mhfrantz]

Fixed by #5060