Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Idea: implement serde serialization (contributions welcome) #5132

Closed
rw opened this issue Jan 19, 2019 · 9 comments
Closed

[Rust] Idea: implement serde serialization (contributions welcome) #5132

rw opened this issue Jan 19, 2019 · 9 comments
Labels

Comments

@rw
Copy link
Collaborator

rw commented Jan 19, 2019

https://serde.rs
https://serde.rs/custom-serialization.html

Questions for further research:

  1. Is it possible?

  2. Is it a good idea?

  3. What's the best way to do it?

Contributions welcome on this!

@aardappel
Copy link
Collaborator

Can Serde support zero-copy style serialization?

@rw
Copy link
Collaborator Author

rw commented Jan 24, 2019

@aardappel I don't know yet.

@rw
Copy link
Collaborator Author

rw commented Mar 12, 2019

Probably a good fit for the object API, if/when it gets developed.

@rw rw added the rust label Mar 12, 2019
@CasperN
Copy link
Collaborator

CasperN commented Aug 20, 2019

FYI for anyone who comes across this issues, I'm working on the object API without use of Serde.

There is a mild conflict on the "source of truth" of the data type. Serde assumes its the rust type, while Flatbuffers uses the schema. I think the best fit for Serde would be Flexbuffers.

@tymcauley
Copy link
Contributor

I noticed under the serde supported data formats, that there's a format with support for schemas: https://github.com/flavray/avro-rs

The code example on that repo's home page shows how they can parse a schema from a raw Rust string. I haven't explored the implementation, but it at least looks like this could be some interesting prior art, if someone gets around to exploring this.

@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jun 15, 2020
@CasperN
Copy link
Collaborator

CasperN commented Jun 16, 2020

Serde support was added with Flexbuffers. I recommend closing this issue

@github-actions github-actions bot removed the stale label Jun 16, 2020
@rw
Copy link
Collaborator Author

rw commented Jun 16, 2020

@CasperN I made a PR to add your work to the serde ecosystem docs :-] serde-rs/serde#1840

@rw
Copy link
Collaborator Author

rw commented Jun 16, 2020

@CasperN Want to add some docs as @dtolnay requested in serde-rs/serde#1840 (review) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants