Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.5: Test flattests fails #7009

Closed
yurivict opened this issue Dec 30, 2021 · 4 comments · Fixed by #7041
Closed

2.0.5: Test flattests fails #7009

yurivict opened this issue Dec 30, 2021 · 4 comments · Fixed by #7041

Comments

@yurivict
Copy link
Contributor

$  ./work/.build/flattests
EXPECTED: "0"
VALUE: "1"
TEST FAILED: /disk-samsung/freebsd-ports/devel/flatbuffers/work/flatbuffers-2.0.5/tests/test.cpp:809, 'flatbuffers::LoadFile( (test_data_path + "monster_test." + (binary ? "bfbs" : "fbs")) .c_str(), binary, &schemafile)' != 'true' in 
Assertion failed: (0), function TestFail, file /disk-samsung/freebsd-ports/devel/flatbuffers/work/flatbuffers-2.0.5/tests/test_assert.cpp, line 24.
Abort trap

Version: 2.0.5
clang-13
OS: FreeBSD 13

@dbaileychess
Copy link
Collaborator

I just got the tip and did

make clean
make -j 64
./flattests

and it passed.

flattests assumes you are in the git root and the tests are in tests/, see: https://github.com/google/flatbuffers/blob/master/tests/test.cpp#L74-L79 It looks like you are building out of the src tree which we don't support.

@dbaileychess
Copy link
Collaborator

@yurivict Is this still an issue for you?

@yurivict
Copy link
Contributor Author

Yes. It should properly build without it being a git repository.

@dbaileychess
Copy link
Collaborator

We could probably add a flag to flattest to pass in the directory for the test. But this isn't real high priority at the moment since it should work if you run it from the correct directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants