CMake Error in recent commits

[dsgibbons]

When running cmake -G "Unix Makefiles", I get the following error with recent commits.

-- Proceeding with version: 23.5.9.23
-- CMAKE_CXX_FLAGS: 
CMake Error at CMakeLists.txt:559 (set_target_properties):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINKER_LANGUAGE" is not allowed.


CMake Error at CMakeLists.txt:512 (target_sources):
  target_sources may only be set INTERFACE properties on INTERFACE targets
Call Stack (most recent call first):
  CMakeLists.txt:561 (compile_schema_for_samples)


-- Configuring incomplete, errors occurred!

This error was introduced with commit 17b9eed and was consistent for both of the following setups:

• Ubuntu 18.04 + cmake 3.10.2
• Ubuntu 20.04 + cmake 3.16.3

The error disappears as soon as I checkout the previous commit that affects CMakeLists.txt: cbc8872

[mikeholler]

I'm also seeing this. Any workaround?

[mikeholler]

I can confirm that 22.04 works, but I would like to see this work with 18.04 and 20.04 given that they're LTS releases.

[wirepair]

For Ubuntu 20.04 LTS I just changed https://github.com/google/flatbuffers/blob/v23.5.26/CMakeLists.txt#L557 to:

  add_library(flatsample STATIC)

and it compiled fine with cmake -G "Unix Makefiles" ../ && make -j8 && sudo make install.

In my project which uses flatbuffers as a dependency, I had to do the following (which I found from some other repositories CMakeLists.txt):

FetchContent_Declare(
  flatbuffers
  GIT_REPOSITORY https://github.com/google/flatbuffers.git
  GIT_TAG v23.5.26
)
FetchContent_GetProperties(flatbuffers)
if (NOT flatbuffers_POPULATED)
    FetchContent_Populate(flatbuffers)
    add_library(flatbuffers INTERFACE)
    add_library(flatbuffers::flatbuffers ALIAS flatbuffers)
    target_include_directories(flatbuffers INTERFACE ${flatbuffers_SOURCE_DIR}/include)
endif()
# Adds flatbuffers

[github-actions]

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

[github-actions]

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.