Emit GetRootAs methods for all types in Go and Python #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the "GetRootAs" methods are really convenient and necessary for reading messages consisting only non-root_type object. |
|
Looks good to me, @rw ? |
ghost
force-pushed
the
master
branch
2 times, most recently
from
b611dc4
to
fe2f8d3
Compare
|
Thanks for submitting this PR. Please add tests that verify all of these work correctly for the example Monster (and so that we can prevent regressions). Otherwise LGTM. |
ghost
mentioned this pull request
Closed
|
Bump @danring |
|
@rw Apologies, I was offline for a week. I'll add tests soon. |
|
@rw Are the added tests sufficient? |
|
Bump @rw -- Any further tests needed? |
|
Hi! Any chance to have this merged somehow? Would help to use gRPC+flatbuffers in Go. Thanks! |
|
@rw? |
|
status? |
|
Thank you, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles part of #341, adding
GetRootAs*methods to non-root tables. Basically just applies the same change from 9f506f5 toidl_gen_python.cppandidl_gen_go.cpp. (Also removes an extra newline from generated Python.)