Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flatbuffers work with ArduinoSTL (#4357) [C++] #4361

Merged
merged 1 commit into from Jun 21, 2017

Conversation

rstoica
Copy link
Contributor

@rstoica rstoica commented Jun 21, 2017

This fixes #4357 by conditionally including utility over utility.h for ArduinoSTL based upon the include guard of the library's header (no better way to check afaik on which lib is in use).

Legacy compatibility with StandardCplusplus lib (utility.h) is maintained.

*Keep legacy compatibility with StandardCplusplus lib (utility.h)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rstoica
Copy link
Contributor Author

rstoica commented Jun 21, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@aardappel
Copy link
Collaborator

Thanks!

@aardappel aardappel merged commit b0fa5e0 into google:master Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed build with Arduino STL [Arduino 1.6+, C++, avr/arm-none-eabi-gcc 4.8, master]
3 participants