Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include subdirectories in published npm JS package #6850

Merged
merged 1 commit into from Sep 23, 2021
Merged

Include subdirectories in published npm JS package #6850

merged 1 commit into from Sep 23, 2021

Conversation

lourd
Copy link
Contributor

@lourd lourd commented Sep 21, 2021

Updates the files globs in package.json to include subdirectories in order to also include the flexbuffers directory in the published npm package.

Updates .gitignore to include the tsc-generated JS files.

Fixes #6849.

Updates the `files` globs in package.json to include subdirectories in order to also include the flexbuffers directory in the published npm package.

Updates .gitignore to include the tsc-generated JS files.
@google-cla
Copy link

google-cla bot commented Sep 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@github-actions github-actions bot added the json label Sep 21, 2021
@lourd
Copy link
Contributor Author

lourd commented Sep 21, 2021

@googlebot I signed it!

@aardappel
Copy link
Collaborator

Thanks, @bjornharrtell can you check?

@bjornharrtell
Copy link
Collaborator

Lgtm

@aardappel
Copy link
Collaborator

Thanks :)

@aardappel aardappel merged commit 9d686bf into google:master Sep 23, 2021
@lourd
Copy link
Contributor Author

lourd commented Sep 24, 2021

Thanks y'all!

When do you think a new version of the npm package will be published?

@aardappel
Copy link
Collaborator

Just tried to npm publish after changing the version in package.json to 2.0.4 (it was 2.0.3), but it ends with npm ERR! 404 'flatbuffers@2.0.4' is not in the npm registry. which.. confuses me.

@lourd lourd deleted the add-flexbuffers-directory branch September 27, 2021 21:27
@lourd
Copy link
Contributor Author

lourd commented Sep 27, 2021

Perhaps npm login again, get a fresh token? Based off npm/cli#1637 (comment))

@aardappel
Copy link
Collaborator

@lourd thanks, that was it. I'm not an npm user outside of making these releases :) Surprised they think the above is an adequate error for not being logged in.

It's on https://www.npmjs.com/package/flatbuffers and 2.0.4 has 95 files instead of the 50 of 2.0.3, which must mean.. things have improved :)

aardappel added a commit that referenced this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing flexbuffers from npm package
3 participants