New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include subdirectories in published npm JS package #6850
Conversation
Updates the `files` globs in package.json to include subdirectories in order to also include the flexbuffers directory in the published npm package. Updates .gitignore to include the tsc-generated JS files.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks, @bjornharrtell can you check? |
Lgtm |
Thanks :) |
Thanks y'all! When do you think a new version of the npm package will be published? |
Just tried to |
Perhaps |
@lourd thanks, that was it. I'm not an npm user outside of making these releases :) Surprised they think the above is an adequate error for not being logged in. It's on https://www.npmjs.com/package/flatbuffers and 2.0.4 has 95 files instead of the 50 of 2.0.3, which must mean.. things have improved :) |
Updates the
files
globs in package.json to include subdirectories in order to also include the flexbuffers directory in the published npm package.Updates .gitignore to include the tsc-generated JS files.
Fixes #6849.