Removed test/generate_code.{sh|bat} #6873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The check generating code scripts would catch people making modifications and then not running the scripts and/or not adding all changes to the PR etc.. how are we covered against that now? |
dbaileychess
force-pushed
the
remove_old_scripts
branch
2 times, most recently
from
f0b19b1
to
042f830
Compare
|
I'm still working on this, getting everything right for all the platforms and configurations is hard! |
remove c++0x from generate_code.py added check generate code script in python add windows specific call added flags to generate_code.py Set c++-0x on BUILD_LEGACY Skip generating monster_extra if requested
dbaileychess
force-pushed
the
remove_old_scripts
branch
from
b6ea644
to
323af2e
Compare
|
@aardappel You can take another look. I got the check generated code back in to CI. I did have to disable it for VS2010 in appveyor because it does produce different generated files due only supporting |
|
Generally LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6857
Remove the old generate_code and check scripts as the code should generated correctly every time. I think if we encounter errors in the future with the code gen not running correctly after a change, we should fix it in that PR.