rust: mark follow method of Follow trait as unsafe
#6951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took the liberty to enable the `unsafe_op_in_unsafe_fn` lint in order to not blindly allow all unsafe code in follow methods.
|
I also ran |
|
For reviewability I would leave any formatting changes to a separate PR. |
CasperN
reviewed
Dec 2, 2021
| @@ -216,6 +216,7 @@ bool GenerateRustModuleRootFile(const Parser &parser, | |||
| for (auto it = sub_modules.begin(); it != sub_modules.end(); it++) { | |||
| code += "pub mod " + it->first + " {"; | |||
| code.IncrementIdentLevel(); | |||
| code += "#![deny(unsafe_op_in_unsafe_fn)]"; | |||
There was a problem hiding this comment.
I think it makes more sense for this to be at the top of the module root file, or at the top of every generated object file. I believe the #![...] attributes will cover all nested modules so there's some redundant coverage and also it currently misses the generated code that's in the root namespace.
No problem, my brain classifies the extra Generally LGTM with one comment |
|
@marmeladema Any update to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty to enable the
unsafe_op_in_unsafe_fnlint inorder to not blindly allow all unsafe code in follow methods.