Add deps attribute to flatbuffer_cc_library #7107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkuszmaul
force-pushed
the
cc_libray_deps
branch
2 times, most recently
from
3b2d2b7
to
f895cef
Compare
|
I need to review this again because rules are never easy, but looks fine so far. Is there a way to test it? If there's already a good example in the repo, we could build that, otherwise make a simple one? |
I'm not seeing the reason why we didn't attempt to support transitive dependencies for flatbuffer_cc_library, and the current setup makes having to propagate new dependencies to all of their recursive dependents obnoxious.
jkuszmaul
force-pushed
the
cc_libray_deps
branch
from
f895cef
to
f00ddee
Compare
|
Added a test. I checked it downstream already, as well. |
|
LGTM, @AustinSchuh are you still wanting to review this? |
|
I'm happy with it. Looks surprisingly straight forwards now that I've gotten enough sleep. The test is also good. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not seeing the reason why we didn't attempt to support transitive
dependencies for flatbuffer_cc_library, and the current setup makes
having to propagate new dependencies to all of their recursive
dependents obnoxious.
cc @AustinSchuh if you remember why this had to be done, or have a cleaner suggestion for managing it....