Fix Clang-Cl compile on Windows #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a MSVC_LIKE variable in the CMake scripts, set that variable to true only if the compiler is either MSVC or tries to emulate the MSVC command line, and test that variable when setting compiler arguments. Tested with cmake .. -G Ninja -DCMAKE_C_COMPILER:PATH="clang-cl.exe" -DCMAKE_CXX_COMPILER:PATH="clang-cl.exe" -DFLATBUFFERS_BUILD_TESTS=OFF -DFLATBUFFERS_BUILD_CPP17=ON
ghost
approved these changes
May 16, 2022
| @@ -75,6 +75,11 @@ option(FLATBUFFERS_SKIP_MONSTER_EXTRA | |||
| "Skip generating monster_extra.fbs that contains non-supported numerical\" | |||
| types." OFF) | |||
|
|
|||
| set(MSVC_LIKE OFF) | |||
There was a problem hiding this comment.
Can you define this inline without the explicit if statement
There was a problem hiding this comment.
I don't seem to find a way to inline the initialization for a "boolean" variable in CMake. The syntax for if(condition) in CMake is special, so the condition here is not an expression that can be used in set.
I am not sure if I understand your comment correctly. If not, can you give an explicit edit suggestion? Thanks!
dbaileychess
approved these changes
Aug 6, 2022
|
Fixes #7334 |
sssooonnnggg
pushed a commit
to sssooonnnggg/flatbuffers
that referenced
this pull request
Aug 8, 2022
Introduce a MSVC_LIKE variable in the CMake scripts, set that variable to true only if the compiler is either MSVC or tries to emulate the MSVC command line, and test that variable when setting compiler arguments. Tested with cmake .. -G Ninja -DCMAKE_C_COMPILER:PATH="clang-cl.exe" -DCMAKE_CXX_COMPILER:PATH="clang-cl.exe" -DFLATBUFFERS_BUILD_TESTS=OFF -DFLATBUFFERS_BUILD_CPP17=ON Co-authored-by: Kaiyi Li <kaiyili@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a MSVC_LIKE variable in the CMake scripts, set that variable to
true only if the compiler is either MSVC or tries to emulate the MSVC
command line, and test that variable when setting compiler arguments.
Tested with cmake .. -G Ninja -DCMAKE_C_COMPILER:PATH="clang-cl.exe" -DCMAKE_CXX_COMPILER:PATH="clang-cl.exe" -DFLATBUFFERS_BUILD_TESTS=OFF -DFLATBUFFERS_BUILD_CPP17=ON