Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement optional scalars for Python #7318

Merged
merged 3 commits into from Jun 13, 2022
Merged

Implement optional scalars for Python #7318

merged 3 commits into from Jun 13, 2022

Conversation

calebzulawski
Copy link
Contributor

Fixes #7317

@google-cla
Copy link

google-cla bot commented May 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@github-actions github-actions bot added c++ codegen Involving generating code from schema python labels May 20, 2022
@kenroser kenroser mentioned this pull request May 23, 2022
Closed
CasperN
CasperN reviewed May 23, 2022
View reviewed changes
tests/py_test.py Outdated Show resolved Hide resolved
tests/py_test.py Outdated Show resolved Hide resolved
tests/optional_scalars/ScalarStuff.py Outdated Show resolved Hide resolved
@CasperN
Copy link
Collaborator

CasperN commented May 23, 2022

Hello, thanks for the PR

ghost
ghost approved these changes May 23, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghost
ghost approved these changes May 23, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calebzulawski
Copy link
Contributor Author

Is the Android CI failure spurious? It doesn't seem to indicate how flatc failed.

@CasperN
Copy link
Collaborator

CasperN commented May 23, 2022

I think the android CI is actually broken by something before this PR (haven't looked into it yet, but I saw the failure on other PRs)

@CasperN
Copy link
Collaborator

CasperN commented May 24, 2022

Hello can you please do the CLA?

ghost
ghost approved these changes May 24, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calebzulawski
Copy link
Contributor Author

Yeah, I'm in the process of finding the person in my company who can sign off on it.

@calebzulawski
Copy link
Contributor Author

Sorry for the delay--the CLA is ready to go.

ghost
ghost approved these changes Jun 13, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CasperN CasperN merged commit 49e1ea3 into google:master Jun 13, 2022
sssooonnnggg pushed a commit to sssooonnnggg/flatbuffers that referenced this pull request Aug 8, 2022
@calebzulawski @sssooonnnggg
Implement optional scalars for Python (google#7318)
6433a67 
* Implement optional scalars for Python

* Use == for integer comparison, remove empty line

* Fix optional type hint

Co-authored-by: Caleb Zulawski <caleb.zulawski@caci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperN CasperN CasperN left review comments

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional Scalars is not supported for Python
2 participants
@calebzulawski @CasperN