Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS] Verifier #7850

Merged
merged 42 commits into from
Apr 5, 2023
Merged

[CS] Verifier #7850

merged 42 commits into from
Apr 5, 2023

Conversation

tira-misu
Copy link
Contributor

Verifier for .Net

Included:

  • user documentation
  • code generation
  • tests

tira-misu and others added 30 commits October 1, 2019 07:51
@tira-misu
Merge pull request #2 from google/master
64639a2 
Pull from google/flatbuffers
@tira-misu
Fix C/C++ Create<Type>Direct with sorted vectors
1d907c5 
If a struct has a key the vector has to be sorted. To sort the vector
you can't use "const".
@tira-misu
Changes due to code review
7827687
@tira-misu
Improve code readability
a78916b
@tira-misu
Merge branch 'master' of https://github.com/tira-misu/flatbuffers int…
0d9e229 
…o master
@tira-misu
Add generate of JSON schema to string to lib
163d43b 
* option indent_step is supported
@tira-misu
Remove unused variables
2793d38
@tira-misu
Fix break in test
79cd673
@tira-misu
Fix style to be consistent with rest of the code
6085fe1
@tira-misu
Merge branch 'master' of https://github.com/tira-misu/flatbuffers int…
7ae0e9d 
…o master
@tira-misu
Merge remote-tracking branch 'upstream/master' into master
0219f66
@tira-misu
Merge branch 'master' of https://github.com/google/flatbuffers
8643e11
@tira-misu
Merge branch 'google:master' into master
b837543
@tira-misu
[TS] Fix reserved words as arguments (google#6955)
eff8031
@tira-misu
Merge remote-tracking branch 'github/master'
3aa4f37
@tira-misu
[TS] Fix generation of reserved words in object api (google#7106)
fd6a5bb
@tira-misu
[TS] Fix generation of object api
cfd969e
@tira-misu
Merge branch 'master' of https://github.com/google/flatbuffers
d37c5cc
@tira-misu
[TS] Fix MakeCamel -> ConvertCase
40a0b4f
@tira-misu
[C#] Fix collision of field name and type name
ca1f851
@tira-misu
Merge branch 'master' of https://github.com/google/flatbuffers
a8ad16a
@tira-misu
Merge branch 'bugfix/csharp'
305e77b
@tira-misu
Merge remote-tracking branch 'github/master'
12d352d
@tira-misu
[TS] Add test for struct of struct of struct
07f65e4
@tira-misu
Update generated files
3eb6b78
@tira-misu
Add missing files
f728905
@tira-misu
[TS] Fix query of null/undefined fields in object api
7aaaedd
@tira-misu
Merge branch 'master' of https://github.com/google/flatbuffers
e68a32b
@tira-misu
Merge branch 'master' of https://github.com/tira-misu/flatbuffers
91553e2
@tira-misu
Merge pull request #3 from google/master
c9bc375 
Pull from google
@github-actions github-actions bot added c# c++ codegen Involving generating code from schema documentation Documentation labels Mar 3, 2023
dbaileychess
dbaileychess reviewed Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@dbaileychess dbaileychess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thanks.

docs/source/doxyfile Outdated Show resolved Hide resolved
tests/KeywordTest/Table2.cs Outdated Show resolved Hide resolved
tests/MyGame/Example/Any.cs Show resolved Hide resolved
tests/MyGame/Example/Stat.cs Outdated Show resolved Hide resolved
tests/FlatBuffers.Test/FlatBuffersFuzzTests.cs Outdated Show resolved Hide resolved
tests/FlatBuffers.Test/FlatBuffersFuzzTests.cs Outdated Show resolved Hide resolved
net/FlatBuffers/FlatBufferVerify.cs Outdated Show resolved Hide resolved
net/FlatBuffers/FlatBufferVerify.cs Outdated Show resolved Hide resolved
net/FlatBuffers/FlatBufferVerify.cs Outdated Show resolved Hide resolved
net/FlatBuffers/FlatBufferVerify.cs Outdated Show resolved Hide resolved
@dbaileychess
Copy link
Collaborator

Great, looks much better. Still one more open question about the default return true, i sort of feel like if we use any default in the verifier, it should be false.

@tira-misu
Copy link
Contributor Author

What about this PR. I think the default true in the open point above is right - see response.
Is there something else to do?

@dbaileychess dbaileychess enabled auto-merge (squash) April 5, 2023 22:25
@dbaileychess dbaileychess merged commit 876a64a into google:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaileychess dbaileychess dbaileychess approved these changes

Assignees
No one assigned
Labels
c# c++ codegen Involving generating code from schema documentation Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tira-misu @dbaileychess