New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix verification for C# unions #7970
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This pull request is stale because it has been open 3 weeks with no activity. Please comment or label |
… into FixEnumVerify
…atbuffers into FixEnumVerify
Yes, that's right. The other commits were just porting changes from the main branch. |
Any updates on this? |
Thanks for the fix. Seems like something the CI should have caught... |
* Fix verification for unions * Run scripts\generate_code.py --------- Co-authored-by: Michael Le <michael.le647@gmail.com>
* Fix verification for unions * Run scripts\generate_code.py --------- Co-authored-by: Michael Le <michael.le647@gmail.com>
The current compiler produces incorrect code (see #7899) for verifying unions when the object API isn't generated. This fixes that.
Also fixes the C# Desktop framework project to build and run correctly.