Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small optimization on "deserialization" and fix on benchmarks again #7982

Merged
merged 3 commits into from May 31, 2023

Conversation

paulovap
Copy link
Collaborator

  • Fix benchmark run after change in flatbuffers-java deps
    Commit 6e214c3 fixes Kotlin build,
    but makes the kotlin-benchmark plugin misses the java classes at
    runtime, causing NotClassFoundError. The alternative to solve the issue
    is to read java's pom.xml to get the latest java version and use it
    as dependency. With that we avoid compilation errors on a new version and
    keep benchmark plugin happy.
  • Remove redundant assign() method (use init() instead)
  • Small optimizations and benchmark on deserialization

Commit 6e214c3 fixes Kotlin build,
but makes the kotlin-benchmark plugin misses the java classes at
runtime, causing NotClassFoundError. The alternative to solve the issue
is to read java's pom.xml to get the latest java version and use it
as dependency. With that we avoid compilation errors on a new version and
keep benchmark plugin happy.
@github-actions github-actions bot added c++ codegen Involving generating code from schema kotlin labels May 29, 2023
@paulovap
Copy link
Collaborator Author

jvm summary:
Benchmark                                          Mode  Cnt         Score         Error  Units
FlatbufferBenchmark.monstersDeserializationJava    avgt    5  60202904,433 ± 2571267,473  ns/op
FlatbufferBenchmark.monstersDeserializationKotlin  avgt    5  63491321,720 ±  582610,015  ns/op
FlatbufferBenchmark.monstersSerializationJava      avgt    5  43302673,950 ±  195710,100  ns/op
FlatbufferBenchmark.monstersSerializationKotlin    avgt    5  46153101,229 ±   87102,836  ns/op

This is the latest from benchmark, for some reason a couple of commits were missing for #7969 although it was pushed 🤷

@dbaileychess dbaileychess enabled auto-merge (squash) May 31, 2023 18:02
@dbaileychess dbaileychess merged commit 85088a1 into google:master May 31, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants