Fix compiling idl_gen_php.cpp against certain STLs #8067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaileychess
approved these changes
Sep 29, 2023
dbaileychess
approved these changes
Sep 29, 2023
|
Thanks! |
candysonya
pushed a commit
to candysonya/flatbuffers
that referenced
this pull request
Jan 8, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use patched libc++ which uses raw pointers as
std::vectoriterators.Compiling flatbuffers against our libc++ results in attempt to decrement rvalue pointer here:
This PR changes the way of adding commas, so that we can remove decrement.