-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET] Add netstandard2.0 as target #8295
Conversation
@ccorsano would you be willing to try this out in your scenario with .NET Source Generators? |
@bjornharrtell I got your changes and was able to integrate the library with my source generator test project, it looks good to me. My little experiment then fell short as my idea required file IO (to generate a bfbs schema then parse it), which, as I now learned is heavily discouraged (to not say forbidden) in source generators. That being said, the alternative way of achieving my current goal is to write a custom MSBuild task, which has the same constraint of requiring netstandard2.0 (due to Visual Studio still running .Net Framework internally). Overall netstandard2.0 is the last bridge to .Net Framework, so I still think it is a valuable target to keep. |
Hmm.. a bridge to .NET Framework is something else which I'm not to keen on myself. |
@bjornharrtell as UWP still uses the .netstandard 2.0, i am unable to install this. |
@pavan709 assuming you mean you can't use flatbuffers without this change. |
@dbaileychess are you willing to accept this? |
yes @bjornharrtell without the support of .netstandard 2.0 it is not possible to install the flatbuffer in UWP, and UWP is widely used framework, .netstandard is not only a bridge to .net framework, rather .netstandard apis are used across the .net implementaions. |
@pavan709 I'm aware of . net standard versions, but I was not aware of UWP. Anyway I support merge of this just need review to get in. |
Any eta on a release? |
ref #8293