Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --model_dir flag as the training code requires this field to be set. #281

Merged

Conversation

mohitreddy1996
Copy link
Contributor

Set model_dir flag in README as the training code expects the flag to be set. Tensorboard summary writer otherwise fails with

"TypeError: Expected binary or unicode string, got None"

@codecov-commenter
Copy link

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   79.39%   79.39%           
=======================================
  Files          34       34           
  Lines        2252     2252           
=======================================
  Hits         1788     1788           
  Misses        464      464           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b937bc9...8753263. Read the comment docs.

@avital avital self-assigned this May 25, 2020
@avital
Copy link
Contributor

avital commented May 25, 2020

Can we also make model_dir no longer have a default, or force it to have a value with flags.flags.mark_flag_as_required('filename')? The error message you got if you didn't set the model_dir flag isn't good.

@copybara-service copybara-service bot merged commit 77b21e2 into google:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants