Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOWTO: Loading MNIST from torchvision #325

Closed
wants to merge 5 commits into from

Conversation

rolandgvc
Copy link
Contributor

Useful small howto on loading torchvision datasets.

@avital
Copy link
Contributor

avital commented Jun 15, 2020

Nice! Tests are failing (https://github.com/google/flax/pull/325/checks?check_run_id=770571323#step:8:202) because of the torchvision dependency. I think you need to update examples/requirements.txt.

@avital
Copy link
Contributor

avital commented Jun 15, 2020

Hmm maybe you also need to update tests_require in setup.py

@avital
Copy link
Contributor

avital commented Jun 23, 2020

@rolandgvc Looks like tests are still failing on GitHub actions, it's not super clear to me why. Can you try running tests locally? Do they pass there?

@avital avital added this to the Design notes and patterns milestone Dec 12, 2020
@avital avital modified the milestones: Design notes, Patterns/HOWTOs Dec 29, 2020
@avital avital added the Priority: P1 - soon Response within 5 business days. Resolution within 30 days. (Assignee required) label Dec 29, 2020
@avital
Copy link
Contributor

avital commented Feb 13, 2021

We've redone our HOWTO system. Here's an example of the new format:

Rendered in ReadTheDocs: https://flax.readthedocs.io/en/latest/howtos/ensembling.html
Document source: https://github.com/google/flax/blob/master/docs/howtos/ensembling.rst (see the :testsetup, :testcode and :codediff directives)

We'd happy take pull requests revamping this HOWTO to the new system.

@avital avital removed their assignment Feb 13, 2021
@avital avital added the Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request label Feb 13, 2021
@marcvanzee marcvanzee added Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. and removed Priority: P1 - soon Response within 5 business days. Resolution within 30 days. (Assignee required) labels Apr 15, 2021
@marcvanzee
Copy link
Collaborator

Closing this and replacing it with #1853

@marcvanzee marcvanzee closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants