updated lm1b example with jit #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiamp
force-pushed
the
lm1b
branch
3 times, most recently
from
d6f118e
to
48bb40d
Compare
marcvanzee
reviewed
Oct 5, 2023
marcvanzee
requested changes
Oct 6, 2023
|
|
||
| # One axis for each parallelism type may hold a placeholder (-1) | ||
| # value to auto-shard based on available slices and devices. | ||
| # By default, product of the DCN axes should equal number of slices |
There was a problem hiding this comment.
Maybe explain what DCN and ICI are, I suppose not everyone knows this.
Codecov Report
@@ Coverage Diff @@
## main #3302 +/- ##
=======================================
Coverage 83.68% 83.68%
=======================================
Files 56 56
Lines 6808 6808
=======================================
Hits 5697 5697
Misses 1111 1111 |
marcvanzee
approved these changes
Oct 16, 2023
|
Looks great, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated lm1b example to use jit instead of pmap.
lm1b now uses both data and model parallelism instead of just data parallelism.