Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jax.Array type for rng keys #3354

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Sep 20, 2023

for more details, see the Jax PR and JEP 9263

@codecov-commenter
Copy link

Codecov Report

Merging #3354 (dbc9254) into main (ae402f3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3354   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files          55       55           
  Lines        6521     6521           
=======================================
  Hits         5415     5415           
  Misses       1106     1106           
Files Changed Coverage Δ
flax/linen/module.py 92.02% <100.00%> (ø)
flax/linen/recurrent.py 97.30% <100.00%> (ø)
flax/linen/stochastic.py 96.77% <100.00%> (ø)

@chiamp chiamp requested a review from IvyZX September 21, 2023 21:47
Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@copybara-service copybara-service bot merged commit d33a33e into google:main Sep 21, 2023
19 checks passed
@chiamp chiamp deleted the dunder branch September 25, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants