Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed nnx dataclass #3742

Merged
merged 1 commit into from
Mar 8, 2024
Merged

removed nnx dataclass #3742

merged 1 commit into from
Mar 8, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Mar 7, 2024

Removed nnx dataclass, after #3720.

Instead of:

@nnx.dataclass
class Foo(nnx.Pytree):
  a: int = nnx.treenode_field()
  b: int = nnx.field()

users should now do:

@dataclasses.dataclass
class Foo(nnx.Pytree):
  a: nnx.TreeNode[int]
  b: int = dataclasses.field()

@chiamp chiamp self-assigned this Mar 7, 2024
@chiamp chiamp requested a review from cgarciae March 7, 2024 21:44
@chiamp chiamp force-pushed the nnx_dataclass branch 3 times, most recently from 3e97e92 to bd555f2 Compare March 7, 2024 22:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (e4282ee) to head (d4ac6c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
- Coverage   58.67%   58.52%   -0.15%     
==========================================
  Files         103      102       -1     
  Lines       12437    12376      -61     
==========================================
- Hits         7297     7243      -54     
+ Misses       5140     5133       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit e8e0b2d into google:main Mar 8, 2024
19 checks passed
@chiamp chiamp mentioned this pull request Mar 8, 2024
@chiamp chiamp deleted the nnx_dataclass branch March 8, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants