Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Test positioning of creative #13

Closed
taymonbeal opened this issue Apr 23, 2021 · 3 comments · Fixed by #34
Closed

Test positioning of creative #13

taymonbeal opened this issue Apr 23, 2021 · 3 comments · Fixed by #34
Assignees
Milestone

Comments

@taymonbeal
Copy link
Member

In particular we want to make sure that there aren't any undesirable borders or margins or anything and that the inner iframe's width and height are the same as the outer one's.

I tried Intersection Observer but that doesn't seem to be able to look through the iframe viewport to see the position relative to the actual browser window. I looked at the WebDriver documentation but didn't see any way to do this. I suppose I could try just measuring each iframe relative to its parent but that seems like a place where mistakes could get in. Still trying to think of other options.

Using a same-origin ad creative might be necessary or at least convenient. The API doesn't currently allow srcdoc and data: URIs are cross-origin, so this might require a change on the build-tooling side.

@taymonbeal taymonbeal self-assigned this Apr 23, 2021
@jeffkaufman
Copy link
Contributor

Does the test framework support screenshot goldens?

@taymonbeal taymonbeal added this to the V1 milestone Apr 23, 2021
@taymonbeal
Copy link
Member Author

Basically no. WebDriver does, although I would still need to figure out how to set up comparisons against goldens.

Currently inclined to just measure each iframe relative to its parent and hope I don't screw it up.

@jeffkaufman
Copy link
Contributor

That, plus an initial manual test, SGTM

taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Apr 26, 2021
taymonbeal added a commit that referenced this issue Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants