New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous String Compare #101

Closed

QiAnXinCodeSafe opened this issue Sep 3, 2019 · 1 comment

QiAnXinCodeSafe commented Sep 3, 2019

flogger/api/src/main/java/com/google/common/flogger/LogContext.java

Line 563 in 477d892

if (message != LITERAL_VALUE_MESSAGE) {

Strings should be compared with the equals() method, not == or !=.

Member

kluever commented Sep 3, 2019 •

edited

Loading

See the comment directly before that line:

Using "!=" is fast and sufficient here because the only real case this should be skipping
is when we called log(String) or log(), which should not result in a template being created.
DO NOT replace this with a string instance which can be interned, or use equals() here,
since that could mistakenly treat other calls to log(String, Object...) incorrectly.

kluever closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment