Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Specific Files For Debugging #106

Merged
merged 2 commits into from Jul 15, 2018
Merged

Add User Specific Files For Debugging #106

merged 2 commits into from Jul 15, 2018

Conversation

CallumIddon
Copy link
Contributor

This will include the debugging configuration required for VS to correctly run the embedder from inside VS. This includes the configuration that the working directory needs to be the solution directory not the project directory.

This will include the debugging configuration required for VS to correctly run the embedder from inside VS. This includes the configuration that the working directory needs to be the solution directory not the project directory.
@CallumIddon CallumIddon mentioned this pull request Jul 13, 2018
@stuartmorgan
Copy link
Collaborator

I don't have access to my Windows machine at the moment to test; does
https://stackoverflow.com/questions/38295289/how-to-store-visual-studios-debug-configuration-in-source-control
still work in VS 2017 so that we wouldn't need to check in the user-specific file?

This removes the need to include the user specific file in the repo.
@CallumIddon
Copy link
Contributor Author

Works for me if you could test it just in case that would be great.

@b-strauss
Copy link

Works great on my machine with Visual Studio Community!

@ghost
Copy link

ghost commented Jul 15, 2018 via email

@ghost
Copy link

ghost commented Jul 15, 2018

I presume by VS you don't mean VS Code ? Just checking

@CallumIddon
Copy link
Contributor Author

@stuartmorgan should be good to land. And yes this is Visual Studio not Visual Studio Code.

@stuartmorgan
Copy link
Collaborator

Great, will land now since it's confirmed working (I wasn't going to be able to test until Monday).

@stuartmorgan stuartmorgan merged commit d03a5ae into google:master Jul 15, 2018
@CallumIddon CallumIddon deleted the VS-Debugging branch July 15, 2018 20:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants