Makefile update. #26
Merged
Makefile update. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue google#19: moving the link statements to the end of the flag declarations appears to fix the build issue.
|
Done. PTAL |
linux/example/Makefile
Outdated
| @@ -75,7 +76,7 @@ $(FLUTTER_EXAMPLE_DIR)/build: | |||
| --local-engine=$(FLUTTER_ENGINE_BUILD); | |||
|
|
|||
| $(BIN_OUT): $(SOURCES) $(LIBRARIES) | |||
| $(CXX) $(SOURCES) $(CXXFLAGS) -o $@ | |||
| $(CXX) $(SOURCES) $(CXXFLAGS) $(CPPFLAGS) $(LDFLAGS) -o $@ | |||
There was a problem hiding this comment.
Let's keep C*FLAGS before the sources list.
stuartmorgan
approved these changes
Mar 12, 2018
|
Closes #19 |
This was referenced Aug 1, 2019
Closed
This was referenced Mar 2, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #19: moving the link statements to the end of the flag
declarations appears to fix the build issue.