Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mediapipe-task-text] Upgrade native_assets_cli #35

Merged
merged 2 commits into from
May 16, 2024

Conversation

dcharkes
Copy link
Member

@dcharkes dcharkes commented May 15, 2024

Description

Bumps the package:native_assets_cli dependency to a newer version.

Notable changes:

  • BuildConfig and BuildOutput are no longer created manually, instead a build method is provided.
  • dry run does no longer have to enumerate all architectures.
    • This means, we don't look at the download uri in dry run. We still need the file-name. Since the names are regular we can derive them from the targetOS.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@dcharkes dcharkes requested a review from craiglabenz May 15, 2024 08:25
@craiglabenz craiglabenz merged commit 5cea89f into main May 16, 2024
3 checks passed
@craiglabenz craiglabenz deleted the migrate-native-assets-cli branch May 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants