Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing unsupported (by MSVC) cast with intrinsic. #18

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

mason-bially
Copy link
Contributor

This cast is not supported by MSVC, however the intrinsic is. The mirror intrinsic (_mm_castps_si128) is already being used so this intrinsic should be supported by anything that was already able to compile this.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@mason-bially
Copy link
Contributor Author

mason-bially commented Sep 29, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

@mason-bially
Copy link
Contributor Author

Probably should have checked first (fixes #14). Looks like a dead project.

@raphlinus raphlinus merged commit 689b33c into raphlinus:master Sep 29, 2017
@raphlinus
Copy link
Owner

Thanks for the fix! It is true I'm not actively working on font-rs anymore, but happy to keep it running.

@mason-bially
Copy link
Contributor Author

Thank you! I was just demoralized because all the open pull requests were this issue.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants