make family_name optional

google · Jul 1, 2022 · 3dc3626 · 3dc3626
1 parent f81124d
commit 3dc3626
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Lib/axisregistry/__init__.py b/Lib/axisregistry/__init__.py
@@ -275,8 +275,10 @@ def build_vf_name_table(ttFont, family_name, siblings=[]):
     build_variations_ps_name(ttFont, family_name)
 
 
-def build_variations_ps_name(ttFont, family_name):
+def build_variations_ps_name(ttFont, family_name=None):
     assert is_variable(ttFont), "Not a VF!"
+    if not family_name:
+        family_name = ttFont["name"].getBestFamilyName()
     font_styles = axis_registry.fallbacks_in_name_table(ttFont)
     if font_styles:
         vf_ps = family_name.replace(" ", "") + "".join(

diff --git a/tests/test_names.py b/tests/test_names.py
@@ -522,7 +522,6 @@ def test_fvar_instance_collisions(fp, sibling_fps, result):
 )
 def test_build_variations_ps_name(fp, result):
     ttFont = TTFont(fp)
-    family_name = ttFont["name"].getBestFamilyName()
-    build_variations_ps_name(ttFont, family_name)
+    build_variations_ps_name(ttFont)
     variation_ps_name = ttFont["name"].getName(25, 3, 1, 0x409).toUnicode()
     assert variation_ps_name == result