Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated 'Open Sans' in repo #22

Closed
eins78 opened this issue Apr 30, 2015 · 7 comments
Closed

Outdated 'Open Sans' in repo #22

eins78 opened this issue Apr 30, 2015 · 7 comments
Assignees

Comments

@eins78
Copy link

eins78 commented Apr 30, 2015

The Google Webfont API says 'Open Sans' was lastModified: '2015-04-27', but the files in this repo were not updated.

Out of curiosity: Do they need to be synced manually? Is there any other way to find out font changes than asking the API? (Ideally I was looking for a changelog because there were visual in the newer version now served by google, but since I haven't found the actual source repo for 'Open Sans' this was my next best bet)

@rsheeter rsheeter self-assigned this May 6, 2015
@rsheeter
Copy link
Collaborator

rsheeter commented May 6, 2015

Last modified can also mean adjustments outside the font file that impact what ends up getting served on Google Fonts. I did a quick check on OpenSans-Regular.ttf and it appears to me the one here should be the latest copy.

@eins78
Copy link
Author

eins78 commented May 6, 2015

@rsheeter I am pretty sure that the font itself was changed, because we are testing the visual output of our styleguide (using Open Sans) by comparing screenshots. This test broke exactly on that 'lastModifed' date…
(Looking at the diffs revealed that kerning of the font changed, if that is of any help).

@rsheeter
Copy link
Collaborator

rsheeter commented May 6, 2015

Can you see for which glyphs kerning shifted? Also on which browser(s)?

It is possible that serving optimizations might have had an impact.

@olsonpm
Copy link

olsonpm commented May 29, 2015

wouldn't a file diff between the font served from google fonts and the github repo solve the issue of what changed?

@davelab6
Copy link
Member

davelab6 commented Aug 25, 2015

There are other problems with Open Sans that I will look into

attachment-1

  • Hinting of the tilde ~ is too strong at 13px (and perhaps other sizes) so that it looks flat, like a minus -:

screen shot 2015-08-25 at 15 24 03

Open Sans has a bug in the Romanian 'locl' implementation. Normally S Cedilla (Ş) and T Cedilla (Ţ) should be replaced by S Comma Below (Ș) and T Comma Below (Ț). Unfortunately "Open Sans" does this the way around, Ș and Ț are replaced by Ş and Ţ. Firefox is hit by this bug, see the following bug reports: OpenSans font shows cedillas instead of commas (Şş instead of Șș) for Romanian language (bug in OpenSans font) https://bugzilla.mozilla.org/show_bug.cgi?id=907793 [ro] "Open Sans" font rendered incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=951141

@davelab6 davelab6 modified the milestone: Update Families Jul 16, 2016
@davelab6 davelab6 modified the milestones: Bugs, Update Families Jul 25, 2016
@davelab6 davelab6 removed the bug label Jul 25, 2016
@davelab6 davelab6 modified the milestones: Bugs in Font Files, Bugs in Font Files Requiring Rebuild, Bugs in Font Files - Requires Upstream Resolution Aug 10, 2016
@laerm0
Copy link
Contributor

laerm0 commented Sep 12, 2017

Naming flaws are solved with @m4rc1e's hotfix, but the tilde problem is still outstanding (#1199) and the Romanian problem is still outstanding (#213). As both of these problem have stand-alone issues, I think we can close this issue. Thoughts, @davelab6?

@davelab6
Copy link
Member

Sounds good

m4rc1e pushed a commit that referenced this issue Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants