-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Harmattan #2509
Comments
Thanks @LornaSIL :) I think @RosaWagner will have some time in July to do this, we just had a quick video call and she says she ran the new family through Font Bakery and found the vertical metrics changed. I see the release notes page says,
I know arabic fonts often treat v metrics in a special way, so I would be curious to learn more about the rationale for how they are set. Is there an upstream git repo and issue tracker for Harmattan that we can post issues to? Rosalie is in Berlin and would be happy to schedule a call with you to go over things too, if that would help :) |
|
Thank you! We changed the line metrics because we added all the characters in the 3 Arabic, Arabic Supplement and Arabic Extended-A blocks which made some of the characters be clipped (they were taller or extended further below the baseline than the characters in v 1.001 did) which is why we increased it. Our goal is always support at least one vowel and shadda above a character and I think one vowel below a character. The FONTLOG.txt also mentions the line metrics The repo is available here for any issues or bugs: https://github.com/silnrsi/font-harmattan |
@LornaSIL I propose this very slight modification to the updated text, and retaining the last 2 paragraphs, what do you think?
|
Yes, I understand that - I'm curious to learn the exact (step by step) thinking behind which values were used :) And also I'd like to confirm the same values are used in both styles. |
Yes, that would be fine. |
I don't know if tagging @bobh0303 will work. I'll check with him when he comes online to see if he wants to explain his complicated spreadsheet! |
Sorry, I didn't realize the last paragraph in the description needs the font website to change (scripts.sil.org/Harmattan > software.sil.org/Harmattan):
|
Yes, he will get an email now with comments on this issue :) I would love to see the sheet and possibly add a new 'arabic v metrics' check to Font Bakery (similar to the CJK one introduced with URL update is good! |
You can find my thinking behind v metrics in this google doc. The process I used to come up with these numbers is somewhat convoluted, and involves a program that analyzes combinations of base + marks to calculate how far they spread ink above/below the baseline and identifying the greatest values. The judgement call is in deciding what subset of glyphs to include in that process. |
It seems this issue has split into two things:
When you ask
to which of these two are you referring? (It might be useful to create a separate issue for 2) |
I want @m4rc1e to review your approach to (2) in order for (1) to proceed |
Concerning (1) I will post issues on the upstream repo ;) |
The update is sent to google/fonts repo : #2533 |
We would like to see an update to the Google fonts version of Harmattan (https://fonts.google.com/specimen/Harmattan) with the just released version 2.000.
The download is available here: https://software.sil.org/harmattan/download/
The most significant change to this version is the addition of a bold typeface.
The first 3 paragraphs under "About Harmattan" could be updated to say:
The text was updated successfully, but these errors were encountered: