Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex Brush: Version 1.110; ttfautohint (v1.8.4.7-5d5b) added #5686

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

vv-monsalve
Copy link
Collaborator

b7867a8: [gftools-packager] Alex Brush: Version 1.110; ttfautohint (v1.8.4.7-5d5b) added

@vv-monsalve vv-monsalve added this to the 2022 Q4 milestone Dec 8, 2022
@vv-monsalve vv-monsalve linked an issue Dec 8, 2022 that may be closed by this pull request
@vv-monsalve
Copy link
Collaborator Author

Updated

Alex Brush: Version 1.110; ttfautohint (v1.8.4.7-5d5b) added


639d928: [gftools-packager] Alex Brush: Version 1.110; ttfautohint (v1.8.4.7-5d5b) added

@vv-monsalve
Copy link
Collaborator Author

Diff2 images
diffbrowsers_glyphs-macOS-11 6 5-x86_64-i386-64bit_firefox_106 0 4
diffbrowsers_text-macOS-11 6 5-x86_64-i386-64bit_chrome_108 0 5359 98

…d5b) added

* Alex Brush Version 1.111; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/googlefonts/alex-brush at commit googlefonts/alex-brush@1a50bd1.
@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Dec 8, 2022

Updated to solve winDescent reported Fail

Alex Brush: Version 1.111; ttfautohint (v1.8.4.7-5d5b) added


9e70b49: [gftools-packager] Alex Brush: Version 1.111; ttfautohint (v1.8.4.7-5d5b) added

@RosaWagner
Copy link
Contributor

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[21] AlexBrush-Regular.ttf
WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • WARN Following glyphs differ greatly from Google Fonts version:
    • Agrave
    • Egrave
    • Euro
    • Igrave
    • Ograve
    • Ugrave
    • Wgrave
    • Ygrave
    • ae
    • agrave and 35 more.

Use -F or --full-lists to disable shortening of long lists.

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • And i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • NULL

    • eight.lf

    • five.lf

    • four.lf

    • nine.lf

    • one.lf

    • seven.lf

    • six.lf

    • three.lf

    • two.lf

    • uni030C.alt

    • And zero.lf
      [code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: percent	Contours detected: 4	Expected: 5

- Glyph name: five	Contours detected: 2	Expected: 1

- Glyph name: at	Contours detected: 3	Expected: 2

- Glyph name: E	Contours detected: 2	Expected: 1

- Glyph name: I	Contours detected: 2	Expected: 1

- Glyph name: K	Contours detected: 3	Expected: 1 or 2

- Glyph name: L	Contours detected: 3	Expected: 1

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: S	Contours detected: 2	Expected: 1

- Glyph name: b	Contours detected: 1	Expected: 2 

- And 188 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • dagger (U+2020): L<<154.0,17.0>--<157.0,55.0>> -> L<<157.0,55.0>--<164.0,147.0>>

    • dagger (U+2020): L<<184.0,403.0>--<104.0,399.0>> -> L<<104.0,399.0>--<61.0,396.0>>

    • emdash (U+2014): L<<44.0,259.0>--<105.0,260.0>> -> L<<105.0,260.0>--<223.0,260.0>>

    • four (U+0034): L<<622.0,615.0>--<624.0,618.0>> -> L<<624.0,618.0>--<633.0,632.0>>

    • And franc (U+20A3): L<<121.0,156.0>--<120.0,152.0>> -> L<<120.0,152.0>--<110.0,119.0>> [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • B (U+0042): B<<772.0,357.0>-<706.0,334.0>-<630.0,333.0>>/B<<630.0,333.0>-<672.0,331.0>-<703.5,311.0>> = 3.4801593269768483

    • Eng (U+014A): B<<551.0,272.0>-<531.0,238.0>-<504.0,197.0>>/B<<504.0,197.0>-<535.0,236.0>-<605.0,296.0>> = 5.113832247283459

    • Eng (U+014A): B<<613.5,-267.5>-<602.0,-289.0>-<603.0,-287.0>>/B<<603.0,-287.0>-<581.0,-328.0>-<551.5,-347.5>> = 1.6523046776507706

    • M (U+004D): B<<606.0,361.0>-<588.0,324.0>-<525.0,226.0>>/L<<525.0,226.0>--<602.0,324.0>> = 5.422000315261428

    • M (U+004D): B<<821.0,242.0>-<815.0,220.0>-<813.0,217.0>>/B<<813.0,217.0>-<817.0,222.0>-<832.5,240.5>> = 4.969740728110216

    • N (U+004E): B<<551.0,272.0>-<531.0,238.0>-<504.0,197.0>>/B<<504.0,197.0>-<535.0,236.0>-<605.0,296.0>> = 5.113832247283459

    • Nacute (U+0143): B<<551.0,272.0>-<531.0,238.0>-<504.0,197.0>>/B<<504.0,197.0>-<535.0,236.0>-<605.0,296.0>> = 5.113832247283459

    • Ncaron (U+0147): B<<551.0,272.0>-<531.0,238.0>-<504.0,197.0>>/B<<504.0,197.0>-<535.0,236.0>-<605.0,296.0>> = 5.113832247283459

    • Ntilde (U+00D1): B<<551.0,272.0>-<531.0,238.0>-<504.0,197.0>>/B<<504.0,197.0>-<535.0,236.0>-<605.0,296.0>> = 5.113832247283459

    • Thorn (U+00DE): B<<344.5,377.0>-<332.0,357.0>-<324.0,346.0>>/B<<324.0,346.0>-<334.0,355.0>-<366.0,364.0>> = 11.985414119079715

    • And 37 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • numbersign (U+0023): L<<41.0,257.0>--<207.0,258.0>>

    • numbersign (U+0023): L<<430.0,213.0>--<233.0,212.0>>

    • numbersign (U+0023): L<<496.0,258.0>--<640.0,259.0>>

    • numbersign (U+0023): L<<508.0,433.0>--<316.0,432.0>>

    • uni20B2 (U+20B2): L<<577.0,218.0>--<356.0,217.0>>

    • And yen (U+00A5): L<<408.0,309.0>--<546.0,310.0>> [code: found-semi-vertical]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
/Users/rosalie/Desktop/QA/fonts/ofl/alexbrush/AlexBrush-Regular.ttf
Dehinted Size 76.7kb
Hinted Size 113.5kb
Increase 36.8kb
Change 48.0 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Familyname must be unique according to namecheck.fontdata.com (com.google.fonts/check/fontdata_namecheck)
  • INFO The family name "AlexBrush" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info. [code: name-collision]
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.111; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO /Users/rosalie/Desktop/QA/fonts/ofl/alexbrush [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 12 51 10 154 0
0% 0% 5% 22% 4% 68% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner added the III Improve rendering / layout by addition of manual hinting, kerning or else label Dec 9, 2022
@RosaWagner RosaWagner merged commit 3f9fd6d into main Dec 9, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_alexbrush branch December 9, 2022 12:59
@vv-monsalve vv-monsalve added --- Live Font is visible on API and removed --- to production labels Jan 16, 2023
@RosaWagner RosaWagner removed this from the 2022 Q4 milestone Feb 24, 2023
@RosaWagner RosaWagner removed the --- Live Font is visible on API label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade III Improve rendering / layout by addition of manual hinting, kerning or else
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Update Alex Brush
2 participants