Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COLRv1 font inconsistent color rendering #7545

Closed
vv-monsalve opened this issue Apr 11, 2024 · 7 comments
Closed

COLRv1 font inconsistent color rendering #7545

vv-monsalve opened this issue Apr 11, 2024 · 7 comments
Labels
I API / Website / Platform fonts.google.com related stuff

Comments

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Apr 11, 2024

Describe the issue

A COLRv1 project, which includes gradients and transparencies, shows rendering issues on the Dev server.

It doesn't consistently display the colors; it seems to need the page to be reloaded since it only shows them after switching between tabs.

  • The first preview after searching works ok
Screen Shot 2024-04-11 at 16 41 03
  • But then on the Specimen tab
    Screen Shot 2024-04-11 at 14 25 08

  • The Type Tester and Glyphs tabs seem to be working well always
    Screen Shot 2024-04-11 at 14 25 15

  • Returning to the search results
    Screen Shot 2024-04-11 at 16 45 04

To Reproduce
Enter the server and follow the above process

Expected behavior
For it to work consistently

Browser used: Chrome Version 123.0.6312.107 (Official Build) (x86_64)

cc @davelab6

@tomasdev
Copy link
Collaborator

Debug info: color is retained when asking a static instance like wght:400. Color is lost when asking for a VF subset like wght:100..700

@anthrotype
Copy link
Member

anthrotype commented Apr 12, 2024

Color is lost when asking for a VF subset like wght:100..700

maybe a bug in hb-subset

@davelab6
Copy link
Member

Tracking internally at b/334968053

@davelab6
Copy link
Member

This is confirmed as a problem with the API and the team is looking into it; Viviana has marked the family as blocked until this is resolved.

@vv-monsalve
Copy link
Collaborator Author

The family is being updated with an added Light color palette. It would be ideal for this fix to happen before the new font is ready. Is it feasible?

@davelab6
Copy link
Member

This was because hb-subset did not support partial instancing of COLRv1 tables but @qxliu76 implemented it! :) so this should be all working in all envs now

@anthrotype
Copy link
Member

Before and independently from fonttools! Good job Ginger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I API / Website / Platform fonts.google.com related stuff
Projects
None yet
Development

No branches or pull requests

4 participants