Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalnia Glaze: Version 1.107 added #7539

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented Apr 11, 2024

Taken from the upstream repo https://github.com/fridamedrano/Kalnia-Glaze at commit fridamedrano/Kalnia-Glaze@65e7c78.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
    - [ ] Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.12.0a6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] KalniaGlaze[wdth,wght].ttf
⚠️ **WARN** Validate location, size and resolution of article images.
  • ⚠️ WARN There are 4 image files in the article directory and they should be moved to an article/images subdirectory:

    • ofl/kalniaglaze/article/Kalnia-Glaze-FridaMedrano-GF-01.png

    • ofl/kalniaglaze/article/Kalnia-Glaze-FridaMedrano-GF-03.png

    • ofl/kalniaglaze/article/Kalnia-Glaze-FridaMedrano-GF-04.png

    • ofl/kalniaglaze/article/Kalnia-Glaze-FridaMedrano-GF-02.png
      [code: misplaced-image-files]

All other checks

[13] KalniaGlaze[wdth,wght].ttf
ℹ️ **INFO** List all superfamily filepaths
  • ℹ️ INFO ofl/kalniaglaze [code: family-path]
⚠️ **WARN** Detect any interpolation issues in the font.
  • ⚠️ WARN Interpolation issues were found in the font:

    • Contour 0 in glyph 'eth.color1': becomes underweight between wght=100,wdth=100 and wght=100,wdth=125.

    • Contour 1 in glyph 'z': becomes underweight between wght=100,wdth=125 and wght=700,wdth=100.

    • Contour 2 in glyph 'X': becomes underweight between wght=100,wdth=125 and wght=700,wdth=100.

    • Contour 4 in glyph 'X': becomes underweight between wght=100,wdth=125 and wght=700,wdth=100.

    • Contour 1 in glyph 'k.color1': becomes underweight between wght=100,wdth=100 and wght=100,wdth=125.

    • Contour 1 in glyph 'z.color1': becomes underweight between wght=100,wdth=125 and wght=700,wdth=100.

    • Contour 1 point 8 has a kink between location wght=100,wdth=125 and location wght=700,wdth=100

    • Contour 2 start point differs in glyph 'sterling' between location wght=100,wdth=125 and location wght=700,wdth=100

    • Contour 0 point 34 has a kink between location wght=700,wdth=100 and location wght=700,wdth=125

    • Contour order differs in glyph 'q': [0, 1, 2, 3] in wght=100,wdth=125, [0, 1, 3, 2] in wght=700,wdth=100.

    • 27 more.

Use -F or --full-lists to disable shortening of long lists. [code: interpolation-issues]

ℹ️ **INFO** Font contains all required tables?
  • ℹ️ INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

⚠️ **WARN** Check font contains no unreachable glyphs
  • ⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:

    • .notdef.color0

    • .null.color0

    • A.color0

    • AE.color0

    • Aacute.color0

    • Abreve.color0

    • Acircumflex.color0

    • Adieresis.color0

    • Agrave.color0

    • Amacron.color0

    • 377 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠️ **WARN** Glyph names are all valid?
  • ⚠️ WARN The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    periodcentered.loclCAT.case.color0 and periodcentered.loclCAT.case.color1 [code: legacy-long-names]
⚠️ **WARN** Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN The dot of soft dotted characters should disappear in other cases, for example: ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ j̦̀ j̦́ ĵ̦ j̦̃ j̦̄ j̦̆ j̦̇ j̦̈ j̦̊ j̦̋ ǰ̦ j̦̒ į̦̀

Your font fully covers the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Bafut (Latn, 158,146 speakers), Mundani (Latn, 34,000 speakers), Avokaya (Latn, 100,000 speakers), Cicipu (Latn, 44,000 speakers), Ma’di (Latn, 584,000 speakers), Gulay (Latn, 250,478 speakers), Koonzime (Latn, 40,000 speakers), Mango (Latn, 77,000 speakers), Dan (Latn, 1,099,244 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ekpeye (Latn, 226,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Yala (Latn, 200,000 speakers), Ejagham (Latn, 120,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Basaa (Latn, 332,940 speakers), Mfumte (Latn, 79,000 speakers), Nzakara (Latn, 50,000 speakers), Ebira (Latn, 2,200,000 speakers), Zapotec (Latn, 490,000 speakers), Nateni (Latn, 100,000 speakers), Makaa (Latn, 221,000 speakers), Sar (Latn, 500,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Dii (Latn, 71,000 speakers), Kom (Latn, 360,685 speakers), Lugbara (Latn, 2,200,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), South Central Banda (Latn, 244,000 speakers), Aghem (Latn, 38,843 speakers), Igbo (Latn, 27,823,640 speakers), Southern Kisi (Latn, 360,000 speakers). [code: soft-dotted]

⚠️ **WARN** Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, coptic, cherokee, tifinagh

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, math, old-permic, malayalam, tifinagh, tai-le, coptic, syriac

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
    23 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

ℹ️ **INFO** EPAR table present in font?
ℹ️ **INFO** Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ️ **INFO** Show hinting filesize impact.
  • ℹ️ INFO Hinting filesize impact:
ofl/kalniaglaze/KalniaGlaze[wdth,wght].ttf
Dehinted Size 384.1kb
Hinted Size 384.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
⚠️ **WARN** Is there kerning info for non-ligated sequences?
  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + b

    • b + f

    • f + h

    • h + hbar

    • hbar + j

    • j + k

    • k + i

    • i + l [code: lacks-kern-info]

ℹ️ **INFO** Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO Latn [code: dlng-tag]

  • ℹ️ INFO Latn [code: slng-tag]

ℹ️ **INFO** Font has old ttfautohint applied?
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.107'] [code: version-not-detected]
[1] Family checks
ℹ️ **INFO** Check axis ordering on the STAT table.
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght-wdth', 1) [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 7 47 8 187 0
0% 0% 0% 3% 19% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve vv-monsalve linked an issue Apr 11, 2024 that may be closed by this pull request
@vv-monsalve
Copy link
Collaborator Author

@emmamarichal this PR addresses the issues reported on #7509 (comment)

@emmamarichal emmamarichal merged commit 4654a50 into main Apr 11, 2024
7 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_kalniaglaze branch April 11, 2024 09:02
@vv-monsalve
Copy link
Collaborator Author

Color rendering issues, reported in #7545. Blocking the PR until they are solved.

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label May 24, 2024
@vv-monsalve vv-monsalve removed a link to an issue Jun 7, 2024
@vv-monsalve vv-monsalve removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants