Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tag tool] Large feature, support tagging all languages/scripts: #8032

Open
2 tasks
davelab6 opened this issue Aug 15, 2024 · 5 comments
Open
2 tasks

[tag tool] Large feature, support tagging all languages/scripts: #8032

davelab6 opened this issue Aug 15, 2024 · 5 comments

Comments

@davelab6
Copy link
Member

davelab6 commented Aug 15, 2024

  • add a 'sample text' dropdown to select all sample_text keys except masthead_* and poster_*; if no sample_text then use exemplar_chars.base. Given use of notdef requested in Fix typos in Alata description #8131, users will see a lot of tofu, but that's OK to start; but to address it, then
  • add 'writing system' and 'language' dropdowns to select scripts and languages, similar to the mock Tomas showed here, using data from https://github.com/googlefonts/lang, so users can filter the families (so families that don't support the script/language selected are no longer shown)
@m4rc1e
Copy link
Collaborator

m4rc1e commented Aug 21, 2024

We currently use the "The quick brown fox" pangram for every family. How about we simply provide a pangram selector that includes different scripts? Imo this is far easier to maintain in the long run. The individual doing the tagging will know what scripts are in the fonts anyway.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Aug 21, 2024

Found a better way, I'll just choose the most appropriate pangram based on the PrimaryScript field for each family.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Aug 27, 2024

Done.

@m4rc1e m4rc1e closed this as completed Aug 27, 2024
@davelab6
Copy link
Member Author

davelab6 commented Aug 28, 2024

Screenshot 2024-08-28 at 5 55 26 PM

Sadly I am not seeing expected results :)

@davelab6 davelab6 reopened this Aug 28, 2024
@davelab6
Copy link
Member Author

based on the PrimaryScript field for each family.

Possibly the families with nothing showing have no Latin? And the ones with Latin samples have no PrimaryScript?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants