Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

majormonodisplay: v2.000 added #1710

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Sep 28, 2018

Taken from the upstream repo https://github.com/googlefonts/majormono at commit googlefonts/majormono@ab4221e


FontBakery Report:

Fontbakery report

[2] MajorMonoDisplay-Regular.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: TTLibError: Not a TrueType or OpenType font (bad sfntVersion)
🔥 FAIL: Checking with Microsoft Font Validator.

Summary

💔 ERROR 🔥 FAIL ⚠️ WARN 💤 SKIP ℹ️ INFO 🍞 PASS
1 1 8 53 4 66
1% 1% 6% 40% 3% 50%

Note: The following loglevels were omitted in this report:

  • WARN
  • SKIP
  • INFO
  • PASS

DiffBrowsers Report:


Fonts: ["MajorMonoDisplay-Regular"]

View: glyphs-all_26pt
PASSED: Desktop_OS_X_El_Capitan_safari_9.1_.jpg is the same

View: waterfall
PASSED: Desktop_Windows_7_chrome_50.0_.jpg is the same
PASSED: Desktop_Windows_10_edge_15.0_.jpg is the same
PASSED: Desktop_Windows_7_ie_9.0_.jpg is the same
PASSED: Desktop_Windows_7_firefox_45.0_.jpg is the same
PASSED: Desktop_OS_X_El_Capitan_safari_9.1_.jpg is the same
PASSED: Google_Nexus_5_android_5.0_Android_Browser_.jpg is the same

alt text

alt text

Imgs
https://drive.google.com/file/d/1lMz8-VXSfXL1lQw0IaDUWJ_l_3-wmnts/view?usp=drivesdk

GFR
http://www.gf-regression.com/compare/ca55b886-a6ff-40fe-82fe-adf2c4423301

Summary
We figured the isfixedpitch FAIL is a false positive, googlefonts/majormono#2 (comment)

@mjlagattuta We need to add a DESCRIPTION.en_us.html file.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@mjlagattuta
Copy link
Contributor

I've added the description for Major Mono from the README

@davelab6 davelab6 merged commit a616937 into google:master Dec 5, 2018
@davelab6
Copy link
Member

davelab6 commented Dec 5, 2018

Thanks Mike!

@davelab6 davelab6 added this to the Add New Families milestone Dec 5, 2018
@davelab6 davelab6 self-assigned this Dec 5, 2018
m4rc1e added a commit to m4rc1e/fonts that referenced this pull request Jan 7, 2019
m4rc1e added a commit to m4rc1e/fonts that referenced this pull request Feb 28, 2019
m4rc1e added a commit to mjlagattuta/fonts that referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants