-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trispace: version 1.210 added #2700
Conversation
Fontbakery reportFontbakery version: 0.7.30 [1] Family checks🔥 FAIL: Do we have the latest version of FontBakery installed?
[2] Trispace[wdth,wght].ttf⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Is there kerning info for non-ligated sequences?--- Rationale --- Fonts with ligatures should have kerning on the corresponding non-ligated sequences for text where ligatures aren't used (eg https://github.com/impallari/Raleway/issues/14).
Summary
Note: The following loglevels were omitted in this report:
Diff images: trispace.zip |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
LGTM |
Fontbakery reportFontbakery version: 0.7.31 [1] Family checks⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?--- Rationale --- There's no reasonable (and legal) way to run the command `ftxvalidator` of the Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc. If Font Bakery is not running on an OSX machine, the machine running Font Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call (rpc). There's an ssh example implementation at: https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds /ftxvalidator/ssh-implementation/ftxvalidator
[2] Trispace[wdth,wght].ttf⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Is there kerning info for non-ligated sequences?--- Rationale --- Fonts with ligatures should have kerning on the corresponding non-ligated sequences for text where ligatures aren't used (eg https://github.com/impallari/Raleway/issues/14).
Summary
Note: The following loglevels were omitted in this report:
Diff images: qa.zip |
* Trispace: version 1.210 added * trispace: readd wdth axis Co-authored-by: Rosalie Wagner <rose.wagner@free.fr> Co-authored-by: Marc Foley <m.foley.88@gmail.com>
Taken at upstream repo https://github.com/Etcetera-Type-Co/Trispace at commit Etcetera-Type-Co/Trispace@6dc2847