Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trispace: version 1.210 added #2700

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Trispace: version 1.210 added #2700

merged 2 commits into from
Sep 30, 2020

Conversation

RosaWagner
Copy link
Contributor

@RosaWagner
Copy link
Contributor Author

Fontbakery report

Fontbakery version: 0.7.30

[1] Family checks
🔥 FAIL: Do we have the latest version of FontBakery installed?

[2] Trispace[wdth,wght].ttf
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: Is there kerning info for non-ligated sequences?
--- Rationale ---

Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).


  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + i
    • i + f
    • f + l
    • l + f
    • i + l

    [code: lacks-kern-info]


Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 2 36 8 134 0
0% 1% 1% 20% 4% 74% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

Diff images: trispace.zip

@google-cla
Copy link

google-cla bot commented Sep 30, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Sep 30, 2020

LGTM

@m4rc1e m4rc1e merged commit b85ab0f into master Sep 30, 2020
@m4rc1e m4rc1e deleted the trispace branch September 30, 2020 11:43
@gf-bot
Copy link

gf-bot commented Sep 30, 2020

Fontbakery report

Fontbakery version: 0.7.31

[1] Family checks
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
--- Rationale ---

There's no reasonable (and legal) way to run the command `ftxvalidator` of the
Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.

If Font Bakery is not running on an OSX machine, the machine running Font
Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure
call (rpc).

There's an ssh example implementation at:
https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds
/ftxvalidator/ssh-implementation/ftxvalidator


  • WARN Could not find ftxvalidator.

[2] Trispace[wdth,wght].ttf
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: Is there kerning info for non-ligated sequences?
--- Rationale ---

Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).


  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + i
    • i + f
    • f + l
    • l + f
    • i + l

    [code: lacks-kern-info]


Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 3 37 8 133 0
0% 0% 2% 20% 4% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

Diff images: qa.zip

@RosaWagner RosaWagner added --- Live Font is visible on API and removed to_production labels Oct 23, 2020
davelab6 pushed a commit that referenced this pull request Dec 10, 2020
* Trispace: version 1.210 added

* trispace: readd wdth axis

Co-authored-by: Rosalie Wagner <rose.wagner@free.fr>
Co-authored-by: Marc Foley <m.foley.88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants