Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minisite_url for Shantell Sans #5830

Merged
merged 1 commit into from Jan 27, 2023
Merged

Added minisite_url for Shantell Sans #5830

merged 1 commit into from Jan 27, 2023

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Jan 26, 2023

No description provided.

@yanone yanone added - Ready for Review I Designer profile Designer profiles related stuff labels Jan 26, 2023
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 2 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght-ital-BNCE-INFM-SPAC', 2) [code: summary]


[18] ShantellSans-Italic[BNCE,INFM,SPAC,wght].ttf
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at ofl/shantellsans failed to parse.
    TRACEBACK:
    54:1 : Message type "google.fonts_public.FamilyProto" has no field named "minisite_url". [code: parsing-error]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL On the font variation axis 'BNCE', the name 'No Bounce' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'BNCE', the name 'Bouncy' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'BNCE', the name 'ExtraBouncy' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'INFM', the name 'Normalized' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'INFM', the name 'Informal' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SPAC', the name 'Max Spacing' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Light Italic' instance has the same coordinates as the default instance; its subfamily name should be 'Italic' [code: invalid-default-instance-subfamily-nameid:320]
WARN: Ensure files are not too large. (com.google.fonts/check/file_size)
  • WARN Font file is 1.4Mb; ideally it should be less than 1.0Mb [code: large-font]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l

    • hyphen + hyphen

    • emdash + emdash

    • emdash + hyphen

    • And hyphen + emdash [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • one.flagless

    • uni004A0301

    • uni006A0301

    • uni030A.A

    • uni20A9.001

    • And zero.dnom_zero
      [code: unreachable-glyphs]

WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
  • WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    overlaystrokeshortcmb (U+0335) [code: spacing-mark-glyphs]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/shantellsans/ShantellSans-Italic[BNCE,INFM,SPAC,wght].ttf
Dehinted Size 1.4Mb
Hinted Size 1.4Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.008;[ac192a2d6]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.008;[ac192a2d6]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • And vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/shantellsans [code: family-path]

[17] ShantellSans[BNCE,INFM,SPAC,wght].ttf
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at ofl/shantellsans failed to parse.
    TRACEBACK:
    54:1 : Message type "google.fonts_public.FamilyProto" has no field named "minisite_url". [code: parsing-error]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL On the font variation axis 'BNCE', the name 'No Bounce' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'BNCE', the name 'Bouncy' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'BNCE', the name 'ExtraBouncy' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'INFM', the name 'Normalized' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'INFM', the name 'Informal' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SPAC', the name 'Max Spacing' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Light' instance has the same coordinates as the default instance; its subfamily name should be 'Regular' [code: invalid-default-instance-subfamily-nameid:320]
WARN: Ensure files are not too large. (com.google.fonts/check/file_size)
  • WARN Font file is 1.2Mb; ideally it should be less than 1.0Mb [code: large-font]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l

    • hyphen + hyphen

    • emdash + emdash

    • emdash + hyphen

    • And hyphen + emdash [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • one.flagless

    • uni004A0301

    • uni006A0301

    • uni030A.A

    • uni20A9.001

    • And zero.dnom_zero
      [code: unreachable-glyphs]

WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
  • WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    overlaystrokeshortcmb (U+0335) [code: spacing-mark-glyphs]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/shantellsans/ShantellSans[BNCE,INFM,SPAC,wght].ttf
Dehinted Size 1.2Mb
Hinted Size 1.2Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.008;[ac192a2d6]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.008;[ac192a2d6]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • And vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/shantellsans [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 6 15 180 15 223 0
0% 1% 3% 41% 3% 51% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@yanone yanone added the I Small Fix bugs fixed but nothing added label Jan 27, 2023
@chrissimpkins chrissimpkins changed the title Added minisize_url for Shantell Sans Added minisite_url for Shantell Sans Jan 27, 2023
@chrissimpkins chrissimpkins merged commit 390533e into main Jan 27, 2023
@chrissimpkins chrissimpkins deleted the shantell_minisite branch January 27, 2023 14:28
@chrissimpkins
Copy link
Collaborator

Thank you!

@RosaWagner RosaWagner added I Article/Description and removed I Designer profile Designer profiles related stuff I Small Fix bugs fixed but nothing added labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants