Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miriam Libre: Version 2.000 added #7534

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

simoncozens
Copy link
Collaborator

NOTE: This is my fork, as the designer appears to have abandoned the original.

Taken from the upstream repo https://github.com/simoncozens/Miriam-Libre at commit googlefonts/Miriam-Libre@72606f9.

@simoncozens simoncozens added III VF Replacement Replace an existing family of static fonts with variable fonts I Font Upgrade II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts labels Apr 10, 2024
@simoncozens simoncozens linked an issue Apr 10, 2024 that may be closed by this pull request
Copy link

FontBakery report

fontbakery version: 0.12.0a6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] MiriamLibre[wght].ttf
⚠️ **WARN** Validate location, size and resolution of article images.
  • ⚠️ WARN Family metadata at ofl/miriamlibre does not have an article.
    [code: lacks-article]
ℹ️ **INFO** METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]

All other checks

[17] MiriamLibre[wght].ttf
ℹ️ **INFO** List all superfamily filepaths
  • ℹ️ INFO ofl/miriamlibre [code: family-path]
⚠️ **WARN** Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]

  • ⚠️ WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]

⚠️ **WARN** Check math signs have the same width.
  • ⚠️ WARN The most common width is 626 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 549:
greater, lessequal, greaterequal, less

Width = 586:
plusminus

Width = 517:
multiply

Width = 612:
approxequal
[code: width-outliers]

ℹ️ **INFO** Font contains all required tables?
  • ℹ️ INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

⚠️ **WARN** Are there any misaligned on-curve points?
  • ⚠️ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • dollar (U+0024): X=157.5,Y=1.0 (should be at baseline 0?)

    • dollar (U+0024): X=380.5,Y=694.5 (should be at cap-height 695?)

    • percent (U+0025): X=642.0,Y=696.0 (should be at cap-height 695?)

    • asterisk (U+002A): X=115.0,Y=693.0 (should be at cap-height 695?)

    • asterisk (U+002A): X=363.0,Y=693.0 (should be at cap-height 695?)

    • asterisk (U+002A): X=368.0,Y=694.5 (should be at cap-height 695?)

    • one (U+0031): X=261.0,Y=694.0 (should be at cap-height 695?)

    • two (U+0032): X=162.0,Y=693.5 (should be at cap-height 695?)

    • five (U+0035): X=345.5,Y=1.5 (should be at baseline 0?)

    • at (U+0040): X=469.0,Y=694.0 (should be at cap-height 695?)

    • 79 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

⚠️ **WARN** Ensure dotted circle glyph is present and can attach marks.
  • ⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ **WARN** Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, cherokee, coptic

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, old-permic, canadian-aboriginal, malayalam, syriac, tifinagh, math, coptic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
    29 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: hebrew, latin, latin-ext, menu [code: unreachable-subsetting]

🔥 **FAIL** Shapes languages in all GF glyphsets.
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
de_Latn (German) Some base glyphs were missing: ẞ
^ Shaper produced a .notdef

[code: failed-language-shaping]

  • ⚠️ WARN GF_Latin_Core glyphset:
Language FAIL messages
de_Latn (German) Some auxiliary glyphs were missing: ẞ

[code: warning-language-shaping]

ℹ️ **INFO** Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ **INFO** EPAR table present in font?
ℹ️ **INFO** Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

🔥 **FAIL** Check Google Fonts glyph coverage.
  • 🔥 FAIL Missing required codepoints:

    • 0x02DC (SMALL TILDE)

    • 0x1E9E (LATIN CAPITAL LETTER SHARP S)
      [code: missing-codepoints]

ℹ️ **INFO** Show hinting filesize impact.
  • ℹ️ INFO Hinting filesize impact:
ofl/miriamlibre/MiriamLibre[wght].ttf
Dehinted Size 121.3kb
Hinted Size 121.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
⚠️ **WARN** Is there kerning info for non-ligated sequences?
  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i

    • i + l [code: lacks-kern-info]

⚠️ **WARN** Ensure variable fonts include an avar table.
  • ⚠️ WARN This variable font does not have an avar table. [code: missing-avar]
ℹ️ **INFO** Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO Hebr [code: dlng-tag]

  • ℹ️ INFO Hebr,Latn [code: slng-tag]

ℹ️ **INFO** Font has old ttfautohint applied?
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000'] [code: version-not-detected]
[1] Family checks
ℹ️ **INFO** Check axis ordering on the STAT table.
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 8 40 10 189 0
0% 0% 1% 3% 16% 4% 76% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Apr 10, 2024

I've just merged #7530, should we block that one?

Would you like to continue hosting the font in your repository? Or should we create a new one under googlefonts?

@simoncozens
Copy link
Collaborator Author

7530 is a different font (Mina).

If we are happy with the fork I would prefer it to be under googlefonts.

@vv-monsalve
Copy link
Collaborator

7530 is a different font (Mina).

Great! Got confused by the names ':)

If we are happy with the fork I would prefer it to be under googlefonts.

There are small spacing and kerning regressions (common pairs likeTO,Yo, Ty).
@davelab6 could you please create the googlefonts repo?
Bold-diffbrowsers_text-Windows-10-10 0 20348-SP0_firefox_124 0 2

@vv-monsalve vv-monsalve added the -- Needs confirmation from upstream or onboarder label Apr 10, 2024
@davelab6
Copy link
Member

davelab6 commented Apr 16, 2024

Taken from the upstream repo simoncozens/Miriam-Libre

If we are happy with the fork I would prefer it to be under googlefonts.

Yes please xfer to me and ping me and I'll move it

To the main regression issue:

Sadly the kerning seems to be regressed quite badly, I would prefer to retain the kerning - but the hinting issues described in #1092 seem worse... @m4rc1e could you help explain more about why the kerning regressed? Or perhaps @simoncozens you can tell :)

Was this totally re-spaced, or was kerning just dropped?

@simoncozens
Copy link
Collaborator Author

It's probable that babelfont tossed the kerning. I'll check.

@simoncozens
Copy link
Collaborator Author

No babelfont involved here, just user error; when I merged the two glyphs sources I didn't include the kerning from the bold master.

@simoncozens simoncozens removed the -- Needs confirmation from upstream or onboarder label Apr 18, 2024
Copy link

FontBakery report

fontbakery version: 0.12.2

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] MiriamLibre[wght].ttf
⚠️ WARN Validate location, size and resolution of article images.
  • ⚠️ WARN

    Family metadata at ofl/miriamlibre does not have an article.


    [code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]

All other checks

[17] MiriamLibre[wght].ttf
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 626 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 549: greaterequal, greater, less, lessequal

Width = 586: plusminus

Width = 517: multiply

Width = 612: approxequal

[code: width-outliers]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* dollar (U+0024): X=157.5,Y=1.0 (should be at baseline 0?)

* dollar (U+0024): X=380.5,Y=694.5 (should be at cap-height 695?)

* percent (U+0025): X=642.0,Y=696.0 (should be at cap-height 695?)

* asterisk (U+002A): X=115.0,Y=693.0 (should be at cap-height 695?)

* asterisk (U+002A): X=363.0,Y=693.0 (should be at cap-height 695?)

* asterisk (U+002A): X=368.0,Y=694.5 (should be at cap-height 695?)

* one (U+0031): X=261.0,Y=694.0 (should be at cap-height 695?)

* two (U+0032): X=162.0,Y=693.5 (should be at cap-height 695?)

* five (U+0035): X=345.5,Y=1.5 (should be at baseline 0?)

* at (U+0040): X=469.0,Y=694.0 (should be at cap-height 695?)

* 79 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
  • ⚠️ WARN

    No dotted circle glyph present


    [code: missing-dotted-circle]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, math, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: syriac, malayalam, tifinagh, coptic, canadian-aboriginal, tai-le, math, old-permic
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage 29 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: hebrew, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table.


    [code: missing-avar]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/miriamlibre


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/miriamlibre/MiriamLibre[wght].ttf
Dehinted Size 122.0kb
Hinted Size 122.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Hebr


    [code: dlng-tag]

  • ℹ️ INFO

    Hebr,Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']


    [code: version-not-detected]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Latin_Core glyphset:

Language FAIL messages
de_Latn (German) Some base glyphs were missing: ẞ
^ Shaper produced a .notdef
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Latin_Core glyphset:

Language WARN messages
de_Latn (German) Some auxiliary glyphs were missing: ẞ
[code: warning-language-shaping]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x02DC (SMALL TILDE)


- 0x1E9E (LATIN CAPITAL LETTER SHARP S)

[code: missing-codepoints]

[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 8 40 10 189 0
0% 0% 1% 3% 16% 4% 76% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

Thanks, Simon.

Now, it would only be a matter of transferring it to googlefonts repo.

@simoncozens
Copy link
Collaborator Author

@davelab6 you already have a fork of the upstream Miriam-Libre so I can't transfer this to you. Delete your fork, and I'll transfer this one.

Also when that is done I will rerelease with correct GitHub URLs in OFL/font/etc.

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Apr 18, 2024
@vv-monsalve
Copy link
Collaborator

I've added the -- Needs Upstream Resolution label as a reminder until this is solved

@m4rc1e m4rc1e self-requested a review April 24, 2024 15:08
Copy link
Collaborator

@m4rc1e m4rc1e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Viv. LGTM

cc @davelab6

@simoncozens simoncozens removed the -- Needs Upstream Resolution Upstream fix required before moving forward label May 27, 2024
@simoncozens
Copy link
Collaborator Author

This is now googlefonts/Miriam-Libre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts III VF Replacement Replace an existing family of static fonts with variable fonts
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Update Miriam Libre
4 participants