-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miriam Libre: Version 2.000 added #7534
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/simoncozens/Miriam-Libre at commit googlefonts/Miriam-Libre@72606f9.
FontBakery reportfontbakery version: 0.12.0a6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] MiriamLibre[wght].ttfAll other checks[17] MiriamLibre[wght].ttf
|
Language | FAIL messages |
---|---|
de_Latn (German) | Some base glyphs were missing: ẞ |
^ | Shaper produced a .notdef |
[code: failed-language-shaping]
⚠️ WARN GF_Latin_Core glyphset:
Language | FAIL messages |
---|---|
de_Latn (German) | Some auxiliary glyphs were missing: ẞ |
[code: warning-language-shaping]
ℹ️ **INFO** Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO Found a git repo URL: https://github.com/simoncozens/Miriam-Libre [code: url-found]
ℹ️ **INFO** EPAR table present in font?
- ℹ️ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]
ℹ️ **INFO** Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]
🔥 **FAIL** Check Google Fonts glyph coverage.
-
🔥 FAIL Missing required codepoints:
-
0x02DC (SMALL TILDE)
-
0x1E9E (LATIN CAPITAL LETTER SHARP S)
[code: missing-codepoints]
-
ℹ️ **INFO** Show hinting filesize impact.
- ℹ️ INFO Hinting filesize impact:
ofl/miriamlibre/MiriamLibre[wght].ttf | |
---|---|
Dehinted Size | 121.3kb |
Hinted Size | 121.4kb |
Increase | 24 bytes |
Change | 0.0 % |
[code: size-impact] |
⚠️ **WARN** Is there kerning info for non-ligated sequences?
-
⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:-
f + i
-
i + l [code: lacks-kern-info]
-
⚠️ **WARN** Ensure variable fonts include an avar table.
⚠️ WARN This variable font does not have an avar table. [code: missing-avar]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 8 | 40 | 10 | 189 | 0 |
0% | 0% | 1% | 3% | 16% | 4% | 76% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
I've just merged #7530, should we block that one? Would you like to continue hosting the font in your repository? Or should we create a new one under |
7530 is a different font (Mina). If we are happy with the fork I would prefer it to be under googlefonts. |
Great! Got confused by the names ':)
There are small spacing and kerning regressions (common pairs like |
Yes please xfer to me and ping me and I'll move it To the main regression issue: Sadly the kerning seems to be regressed quite badly, I would prefer to retain the kerning - but the hinting issues described in #1092 seem worse... @m4rc1e could you help explain more about why the kerning regressed? Or perhaps @simoncozens you can tell :) Was this totally re-spaced, or was kerning just dropped? |
It's probable that babelfont tossed the kerning. I'll check. |
No babelfont involved here, just user error; when I merged the two glyphs sources I didn't include the kerning from the bold master. |
FontBakery reportfontbakery version: 0.12.2 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] MiriamLibre[wght].ttfAll other checks[17] MiriamLibre[wght].ttf
|
ofl/miriamlibre/MiriamLibre[wght].ttf | |
---|---|
Dehinted Size | 122.0kb |
Hinted Size | 122.1kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
-
ℹ️ INFO
Hebr
[code: dlng-tag] -
ℹ️ INFO
Hebr,Latn
[code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied?
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']
[code: version-not-detected]
🔥 FAIL Shapes languages in all GF glyphsets.
- 🔥 FAIL
GF_Latin_Core glyphset:
Language | FAIL messages |
---|---|
de_Latn (German) | Some base glyphs were missing: ẞ |
^ | Shaper produced a .notdef |
⚠️ WARNGF_Latin_Core glyphset:
Language | WARN messages |
---|---|
de_Latn (German) | Some auxiliary glyphs were missing: ẞ |
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 8 | 40 | 10 | 189 | 0 |
0% | 0% | 1% | 3% | 16% | 4% | 76% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Thanks, Simon. Now, it would only be a matter of transferring it to googlefonts repo. |
@davelab6 you already have a fork of the upstream Miriam-Libre so I can't transfer this to you. Delete your fork, and I'll transfer this one. Also when that is done I will rerelease with correct GitHub URLs in OFL/font/etc. |
I've added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Viv. LGTM
cc @davelab6
This is now googlefonts/Miriam-Libre. |
NOTE: This is my fork, as the designer appears to have abandoned the original.
Taken from the upstream repo https://github.com/simoncozens/Miriam-Libre at commit googlefonts/Miriam-Libre@72606f9.