Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Imperial Aramaic: Version 2.002; ttfautohint (v1.8.4.7-5d5b) added #7686

Merged
merged 1 commit into from
May 24, 2024

Conversation

simoncozens
Copy link
Collaborator

@simoncozens simoncozens commented May 16, 2024

Taken from the upstream repo https://github.com/notofonts/imperial-aramaic at commit notofonts/imperial-aramaic@f32017c.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@simoncozens
Copy link
Collaborator Author

This very minor update adds a default languagesystem.

Copy link

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoSansImperialAramaic-Regular.ttf
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]

All other checks

[13] NotoSansImperialAramaic-Regular.ttf
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2
  • Glyph name: uogonek Contours detected: 2 Expected: 1

  • Glyph name: aogonek Contours detected: 3 Expected: 2

  • Glyph name: uogonek Contours detected: 2 Expected: 1


[code: contour-count]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322: minus

[code: width-outliers]
⚠️ WARN Are any segments inordinately short?
  • ⚠️ WARN

    The following glyphs have segments which seem very short:

* u10842 (U+10842) contains a short segment B<<467.0,675.0>-<467.0,679.0>-<470.0,687.0>>

* u10842 (U+10842) contains a short segment B<<470.0,687.0>-<473.0,695.0>-<473.0,698.0>>

* u10843 (U+10843) contains a short segment B<<472.0,705.0>-<474.0,710.0>-<475.5,715.0>>

* u10843 (U+10843) contains a short segment B<<475.5,715.0>-<477.0,720.0>-<479.0,725.0>>

* u10844 (U+10844) contains a short segment B<<300.0,559.0>-<293.0,556.0>-<286.0,552.5>>

* u10844 (U+10844) contains a short segment B<<286.0,552.5>-<279.0,549.0>-<273.0,547.0>>

* u10847 (U+10847) contains a short segment B<<197.0,573.0>-<197.0,578.0>-<196.5,592.5>>

* u10848 (U+10848) contains a short segment B<<526.5,481.0>-<517.0,484.0>-<509.0,484.0>>

* u1084C (U+1084C) contains a short segment B<<543.0,455.5>-<542.0,466.0>-<540.0,474.0>>

* u10853 (U+10853) contains a short segment B<<497.0,697.0>-<499.0,707.0>-<502.0,712.5>>

* 75 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-short-segments]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
  • ⚠️ WARN

    No dotted circle glyph present


    [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Fur (Latn, 1,230,163 speakers), Koonzime (Latn, 40,000 speakers), Makaa (Latn, 221,000 speakers), Ekpeye (Latn, 226,000 speakers), Cicipu (Latn, 44,000 speakers), Navajo (Latn, 166,319 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Dii (Latn, 71,000 speakers), Ma’di (Latn, 584,000 speakers), Avokaya (Latn, 100,000 speakers), Nzakara (Latn, 50,000 speakers), Mundani (Latn, 34,000 speakers), South Central Banda (Latn, 244,000 speakers), Southern Kisi (Latn, 360,000 speakers), Lugbara (Latn, 2,200,000 speakers), Ebira (Latn, 2,200,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Yala (Latn, 200,000 speakers), Aghem (Latn, 38,843 speakers), Vute (Latn, 21,000 speakers), Dan (Latn, 1,099,244 speakers), Igbo (Latn, 27,823,640 speakers), Sar (Latn, 500,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Gulay (Latn, 250,478 speakers), Bafut (Latn, 158,146 speakers), Ejagham (Latn, 120,000 speakers), Mfumte (Latn, 79,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Mango (Latn, 77,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Zapotec (Latn, 490,000 speakers), Nateni (Latn, 100,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Basaa (Latn, 332,940 speakers), Kom (Latn, 360,685 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, cherokee, tifinagh, math
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, tifinagh, malayalam, coptic, old-permic, canadian-aboriginal, syriac, math
  • U+030A COMBINING RING ABOVE: try adding syriac 5 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: imperial-aramaic, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Combined length of family and style must not exceed 32 characters.
  • ⚠️ WARN

    Name ID 6 'NotoSansImperialAramaic-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/notosansimperialaramaic


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notosansimperialaramaic/NotoSansImperialAramaic-Regular.ttf
Dehinted Size 36.4kb
Hinted Size 51.2kb
Increase 14.7kb
Change 40.4 %
[code: size-impact]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 8 64 7 172 0
0% 0% 0% 3% 25% 3% 69% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

@simoncozens there is a tofu in Latin
noto-imperialaramaic-ba

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label May 23, 2024
@simoncozens
Copy link
Collaborator Author

simoncozens commented May 24, 2024

The Latin tofu is fine; LATIN SMALL LETTER ENG and LATIN CAPITAL LETTER ENG are no longer part of the GF Latin Core. (Maybe our test text should be updated.)

@vv-monsalve
Copy link
Collaborator

(Maybe our test text should be updated.)

This sample text is created dynamically based on the languages supported by the font to deliver multiple strings that could reflect them.

@m4rc1e what could be done here?

@vv-monsalve vv-monsalve removed the -- Needs Upstream Resolution Upstream fix required before moving forward label May 24, 2024
@vv-monsalve vv-monsalve merged commit e1ff753 into main May 24, 2024
7 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_notosansimperialaramaic branch May 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

None yet

2 participants