Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Noto Emoji to the 3.002 releasewq #7824

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update Noto Emoji to the 3.002 releasewq #7824

merged 1 commit into from
Jun 5, 2024

Conversation

rsheeter
Copy link
Collaborator

@rsheeter rsheeter commented Jun 5, 2024

@rsheeter rsheeter merged commit b979dba into main Jun 5, 2024
6 checks passed
@rsheeter rsheeter deleted the bwe branch June 5, 2024 21:32
Copy link

github-actions bot commented Jun 5, 2024

FontBakery report

fontbakery version: 0.12.7

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] NotoEmoji[wght].ttf
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/notoemoji does not have an article.


    [code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]

All other checks

[32] NotoEmoji[wght].ttf
🔥 FAIL Font contains glyphs for whitespace characters?
  • 🔥 FAIL

    Whitespace glyph missing for codepoint 0x00A0.


    [code: missing-whitespace-glyph-0x00A0]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
  • 🔥 FAIL

    Please add a family.source.repository_url entry.


    [code: lacks-repo-url]
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets.
  • 🔥 FAIL

    Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".


    [code: missing]
🔥 FAIL METADATA.pb subsets should be alphabetically ordered.
  • 🔥 FAIL

    METADATA.pb subsets are not sorted in alphabetical order: Got ['menu', 'emoji'] and expected ['emoji', 'menu']


    [code: not-sorted]
🔥 FAIL Check for METADATA subsets with zero support.
  • 🔥 FAIL

    Please remove the unrecognized subset 'emoji' from the METADATA.pb file.


    [code: unknown-subset]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Check for presence of an ARTICLE.en_us.html file
  • 🔥 FAIL

    This is a Noto font but it lacks an ARTICLE.en_us.html file.


    [code: missing-article]
🔥 FAIL Check copyright namerecords match license file.
  • 🔥 FAIL

    License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1. This Font Software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://openfontlicense.org"


    [code: wrong]
🔥 FAIL Check license file has good copyright string.
  • 🔥 FAIL

    First line in license file is:

"copyright 2013 google llc"

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)"

[code: bad-format]
🔥 FAIL Copyright notices match canonical pattern in fonts
  • 🔥 FAIL

    Name Table entry: Copyright notices should match a pattern similar to:

"Copyright 2020 The Familyname Project Authors (git url)"

But instead we have got:

"Copyright 2013 Google LLC"

[code: bad-notice-format]
  • 🔥 FAIL

    METADATA.pb: Copyright notices should match a pattern similar to:

"Copyright 2020 The Familyname Project Authors (git url)"

But instead we have got:

"Copyright 2013, 2022 Google Inc. All Rights Reserved."

[code: bad-notice-format]
  • 🔥 FAIL

    Copyright notices differ between name table entries and METADATA.pb.The following copyright values were found:

- Copyright 2013 Google LLC: Name Table entry

- Copyright 2013, 2022 Google Inc. All Rights Reserved.: METADATA.pb

[code: mismatch]

🔥 FAIL Check variable font instances
  • 🔥 FAIL

    fvar instances are incorrect:

  • Add missing instances
Name current expected
Light wght=300.0 wght=300.0
Regular wght=400.0 wght=400.0
Medium N/A wght=500.0
SemiBold N/A wght=600.0
Bold wght=700.0 wght=700.0
[code: bad-fvar-instances]
🔥 FAIL Check glyphs do not have components which are themselves components.
  • 🔥 FAIL

    The following glyphs have components which themselves are component glyphs:

  • u1F478


    [code: found-nested-components]
🔥 FAIL Check font can render its own name.
  • 🔥 FAIL

    .notdef glyphs were found when attempting to render Noto Emoji


    [code: render-own-name]
🔥 FAIL Font enables smart dropout control in "prep" table instructions?
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
⚠️ WARN Checking correctness of monospaced metadata.
⚠️ WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value
  • ⚠️ WARN

    GPOS table lacks kerning information.


    [code: lacks-kern-info]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 7 start point differs in glyph 'coin' between location wght=300 and location wght=700

- Contour 4 start point differs in glyph 'openMailboxWithRaisedFlag' between location wght=400 and location wght=300

- Contour 4 start point differs in glyph 'openMailboxWithRaisedFlag' between location wght=300 and location wght=700

- Contour 3 start point differs in glyph 'u1F493' between location wght=300 and location wght=700

- Contour 3 in glyph 'u1F493': becomes underweight between wght=300 and wght=700.

- Contour 3 point 16 in glyph 'u1F493' has a kink between location wght=300 and location wght=700

- Contour 4 start point differs in glyph 'emojiComponentRedHair' between location wght=400 and location wght=300

- Contour 4 in glyph 'emojiComponentRedHair': becomes underweight between wght=400 and wght=300.

[code: interpolation-issues]

⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- flagBritishIndianOceanTerritory

- flagHeardMcdonaldIslands

- flagNorway

- flagSvalbardJanMayen

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    faceWithOpenEyesAndHandOverMouth, flagSouthGeorgiaSouthSandwichIslands, grinningFaceWithOneLargeAndOneSmallEye, handWithIndexFingerAndThumbCrossed, personInManualWheelchairFacingRight, personInMotorizedWheelchairFacingRight and smilingFaceWithSmilingEyesAndThreeHearts


    [code: legacy-long-names]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* blackHeart (U+1F5A4) has a counter-clockwise outer contour

* blackMediumSmallSquare (U+25FE) has a counter-clockwise outer contour

* blackMediumSquare (U+25FC) has a counter-clockwise outer contour

* blueSquare (U+1F7E6) has a counter-clockwise outer contour

* brownCircle (U+1F7E4) has a counter-clockwise outer contour

* brownHeart (U+1F90E) has a counter-clockwise outer contour

* brownSquare (U+1F7EB) has a counter-clockwise outer contour

* cricketBatAndBall (U+1F3CF) has a counter-clockwise outer contour

* eight (U+0038) has a counter-clockwise outer contour

* euroBanknote (U+1F4B6) has a counter-clockwise outer contour

* 84 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN METADATA.pb: Check for primary_script
  • ⚠️ WARN

    METADATA.pb: primary_script field should be 'Hani' but is missing.
    Make sure that 'Hani' is actually the correct one (out of Jpan, Hani, Hant, Hans).


    [code: missing-primary-script]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+200D ZERO WIDTH JOINER: try adding one of: arabic, batak, mahajani, kharoshthi, manichaean, tai-le, gunjala-gondi, chakma, duployan, javanese, kannada, khojki, masaram-gondi, sharada, pahawh-hmong, tamil, dogra, tirhuta, thai, yi, warang-citi, buhid, old-hungarian, sundanese, syloti-nagri, limbu, oriya, takri, siddham, gujarati, thaana, tagalog, avestan, rejang, psalter-pahlavi, phags-pa, buginese, kaithi, grantha, devanagari, bengali, brahmi, newa, tagbanwa, balinese, sinhala, hebrew, mandaic, tai-tham, malayalam, kayah-li, lepcha, mongolian, zanabazar-square, gurmukhi, lao, modi, syriac, hanifi-rohingya, telugu, bhaiksuki, new-tai-lue, tifinagh, khudawadi, sogdian, nko, cham, myanmar, khmer, tai-viet, meetei-mayek, hanunoo, saurashtra, tibetan
  • U+203C DOUBLE EXCLAMATION MARK: not included in any glyphset definition
  • U+2049 EXCLAMATION QUESTION MARK: try adding mongolian
  • U+20E3 COMBINING ENCLOSING KEYCAP: try adding symbols
  • U+2139 INFORMATION SOURCE: not included in any glyphset definition
  • U+2194 LEFT RIGHT ARROW: try adding one of: symbols, math
  • U+2195 UP DOWN ARROW: try adding one of: symbols, math
  • U+2196 NORTH WEST ARROW: try adding one of: symbols, math
  • U+2197 NORTH EAST ARROW: try adding one of: symbols, math
  • U+2198 SOUTH EAST ARROW: try adding one of: symbols, math 1461 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu, emoji

[code: unreachable-subsetting]
⚠️ WARN Does the font contain less than 150 CJK characters?
  • ⚠️ WARN

    There are only 2 CJK glyphs when there needs to be at least 150 in order to support the smallest CJK writing system, Kana.
    The following CJK glyphs were found:
    ['japaneseCongratulationsButton', 'japaneseSecretButton']
    Please check that these glyphs have the correct unicodes.


    [code: cjk-not-enough-glyphs]
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 1.9Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0A - Use grayscale rendering - Use smoothing along multiple axes with ClearType®

[code: ranges]
  • ⚠️ WARN

    The gasp range 0xFFFF value 0x0A should be set to 0x0F.


    [code: unset-flags]
⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table.


    [code: missing-avar]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/notoemoji


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notoemoji/NotoEmoji[wght].ttf
Dehinted Size 1.9Mb
Hinted Size 1.9Mb
Increase 0 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.002']


    [code: version-not-detected]
[2] Family checks
🔥 FAIL OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts.
  • 🔥 FAIL

    OS/2.fsSelection bit 7 (USE_TYPO_METRICS) wasNOT set in the following fonts: ['ofl/notoemoji/NotoEmoji[wght].ttf'].


    [code: missing-os2-fsselection-bit7]
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 15 14 52 7 160 0
0% 0% 6% 6% 21% 3% 65% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant