VS 2015 compilation issue

[kanstantsin-chernik]

Hello,

As I understood from closed issues is that VS 2015 Update 3 is supported with fruit, isn't it?
I was just download repository, generated debug 32 project and pressed build~
After this I received quite a lot of issues related to one file injector.defn.h:

Error C2061 syntax error: identifier 'RemoveAnnotations<`template-type-parameter-1'>' fixed_size_vector-exec fruit-master\include\fruit\impl\injector.defn.h 99

Could you help me to understand what I am doing wrong?
Thank you for your time!

[poletti-marco]

Only VS 2017 is supported, compilation errors in VS 2015 are a known issue unfortunately (due to VS bugs). Would it be possible for you to update? Also, in any case, could you please point me at the page that gave you the impression that VS 2015 was supported? (So that I can add a note there so that other people won't be misled into thinking it's supported). On 24 May 2017 1:35 pm, "chenar" <notifications@github.com> wrote: Hello, As I understood from closed issues is that VS 2015 Update 3 is supported with fruit, isn't it? I was just download repository, generated debug 32 project and pressed build~ After this I received quite a lot of issues related to one file injector.defn.h: Error C2061 syntax error: identifier 'RemoveAnnotations<`template-type-parameter-1'>' fixed_size_vector-exec fruit-master\include\fruit\impl\injector.defn.h 99 Could you help me to understand what I am doing wrong? Thank you for your time! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#49>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABeeF5HrAioTeAADLoNYcdA5b7hA2Oqiks5r9CQOgaJpZM4NlCq5> .

[kanstantsin-chernik]

Thank you for answer!
It is ok. We are on our way in moving source base to VS17.

I've looked at wiki/install and found that VS isn't supported.
Then I've opened issue issue 9 where I got that VS2017 is supported for sure. It means that wiki page is out dated. Actually, you've posted 2 messages, first that you are not going to add 2015 support and second that is was easier than expected with no version mentioned and closed issue. I just made a wrong assumption.
BTW, then I got through appveyor jobs and realized that 2015 isn't supported but already posted this issue :)

Thank you for nice solution. I am going to integrate it till the end of summer.

[poletti-marco]

Great. Btw, the inconsistency between the wiki and the code+bug tracker is because the wiki describes the latest release, not HEAD. But by then there should be a stable release with VS support (I plan to release 2.1.0 in a few weeks if everything goes as expected). On 24 May 2017 8:45 pm, "chenar" <notifications@github.com> wrote: Closed #49 <#49>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#49 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABeeF0yu9NaU1LAZbZ6-UKXJXHU3t2m_ks5r9IjhgaJpZM4NlCq5> .

[Paxxi]

I'm still on VS2015 for the foreseeable future so I decided to look into the error. The following changes solves the compile issue

diff --git a/include/fruit/component.h b/include/fruit/component.h
index 6ca41e8..1081403 100644
--- a/include/fruit/component.h
+++ b/include/fruit/component.h
@@ -649,9 +649,9 @@ public:
    * other components.
    */
   template <typename OtherComponent, typename... Args>
-  PartialComponentWithReplacementInProgress<OtherComponent, Args...> replace(
+  auto replace(
       OtherComponent(*)(Args...),
-      Args... args);
+      Args... args) -> auto;

   ~PartialComponent();

diff --git a/include/fruit/impl/component.defn.h b/include/fruit/impl/component.defn.h
index b3303ef..ce55024 100644
--- a/include/fruit/impl/component.defn.h
+++ b/include/fruit/impl/component.defn.h
@@ -260,8 +260,8 @@ PartialComponent<Bindings...>::install(OtherComponent(*fun)(Args...), Args... ar

 template <typename... Bindings>
 template <typename OtherComponent, typename... ReplacedFunArgs>
-inline PartialComponent<Bindings...>::PartialComponentWithReplacementInProgress<OtherComponent, ReplacedFunArgs...>
-PartialComponent<Bindings...>::replace(OtherComponent(*fun)(ReplacedFunArgs...), ReplacedFunArgs... args) {
+inline auto
+PartialComponent<Bindings...>::replace(OtherComponent(*fun)(ReplacedFunArgs...), ReplacedFunArgs... args) -> auto {
   using IntCollector = int[];
   (void)(IntCollector{0, checkAcceptableComponentInstallArg<ReplacedFunArgs>()...});

[poletti-marco]

I gave that patch a try, but it doesn't seem to be enough.
After playing around with it a bit more, with additional changes I was able to get Fruit to compile under MSVC 2015, but when running the tests I got some runtime crashes (that don't occur with other compilers nor with MSVC 2017). So I'm afraid I'm unable to support Fruit under MSVC 2015 for the time being.
If you're curious and/or you have time to look into it, I've committed my patch as 8d00ef4 (in a separate msvc-2015 branch, not in master).