Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/fscrypt: fix missing protector error format #275

Merged
merged 1 commit into from Jan 19, 2021
Merged

cmd/fscrypt: fix missing protector error format #275

merged 1 commit into from Jan 19, 2021

Conversation

hobbitalastair
Copy link
Contributor

This is the bugette mentioned in #272 - the format specifiers were never being filled in.
Also add a newline so the prompt to select a protector shows on a separate line.

@google-cla
Copy link

google-cla bot commented Jan 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hobbitalastair
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@ebiggers ebiggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add Update #272 to the commit message so that it directly links to the bug report?

cmd/fscrypt/prompt.go Outdated Show resolved Hide resolved
@hobbitalastair
Copy link
Contributor Author

@ebiggers thanks for the review, good point about the long line

I've called the formatted text loadWarning to be more descriptive, happy to change if you would rather the shorter version.

@ebiggers ebiggers merged commit 99ef2db into google:master Jan 19, 2021
@ebiggers
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants