Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastcgs] Update commit #141

Merged
merged 1 commit into from
Mar 23, 2020
Merged

[fastcgs] Update commit #141

merged 1 commit into from
Mar 23, 2020

Conversation

alifahmed
Copy link
Contributor

Changed base fuzzer to original MOpt

@alifahmed alifahmed changed the title Update commit of fastcgs [fastcgs] Update commit Mar 22, 2020
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 12717d8 into google:master Mar 23, 2020
@alifahmed
Copy link
Contributor Author

@jonathanmetzman The last report does not show any fastcgs results. I am wondering what could be the reason?

@jonathanmetzman
Copy link
Contributor

Sorry which report are you referring to?

@alifahmed
Copy link
Contributor Author

Sorry which report are you referring to?

Sorry, this one: https://www.fuzzbench.com/reports/2020-03-19/index.html

@jonathanmetzman
Copy link
Contributor

Looking into it, but those results are still being processed and aren't complete yet.

@jonathanmetzman
Copy link
Contributor

Looking into it, but those results are still being processed and aren't complete yet.

It also looks like fastcgs failed because we were using multiple -d options. Sorry about that.
I think this PR fixes that issue, so we can rerun fastcgs with newest version.

@alifahmed
Copy link
Contributor Author

Looking into it, but those results are still being processed and aren't complete yet.

It also looks like fastcgs failed because we were using multiple -d options. Sorry about that.
I think this PR fixes that issue, so we can rerun fastcgs with newest version.

No problem :) Eagerly waiting to see how the newest commit does.

@alifahmed
Copy link
Contributor Author

Looking into it, but those results are still being processed and aren't complete yet.

It also looks like fastcgs failed because we were using multiple -d options. Sorry about that.
I think this PR fixes that issue, so we can rerun fastcgs with newest version.

@jonathanmetzman Just saw that the Mar 19 report is online: https://www.fuzzbench.com/reports/2020-03-19/index.html
However, fastcgs results are not shown in the graphs. Curious if the benchmarks are ran with this commit, or the previous commit with the duplicate '-d' options?

Also, if it actually failed to run, I am wondering why it got higher rank than aflsmart, libfuzzer-asan, and libfuzzer in the critical difference plot?

@jonathanmetzman
Copy link
Contributor

The 2020-03-19 report is indeed the one where fastcgs was broken because of duplicate -d instructions.
As for why it got a higher rank, I think it's because fastcgs shows up in the openssl results I think because of a slight bug in how we zip corpora (after fuzzing stops (usually when time expires) we do one last zip of the corpus, but in this case the fuzzing stops immediately).
Our aggregate ranking algorithm doesn't seem to penalize fuzzers for not appearing on a particular benchmark, so that is why fastcgs does better than some fuzzers that consistently end in last.

The results from the latest experiment where fastcgs runs properly should be available soon. I'll try to produce a report where fuzzers run in the latest experiment replace results from 2020-03-19

@alifahmed
Copy link
Contributor Author

alifahmed commented Mar 25, 2020

The 2020-03-19 report is indeed the one where fastcgs was broken because of duplicate -d instructions.
As for why it got a higher rank, I think it's because fastcgs shows up in the openssl results I think because of a slight bug in how we zip corpora (after fuzzing stops (usually when time expires) we do one last zip of the corpus, but in this case the fuzzing stops immediately).
Our aggregate ranking algorithm doesn't seem to penalize fuzzers for not appearing on a particular benchmark, so that is why fastcgs does better than some fuzzers that consistently end in last.

The results from the latest experiment where fastcgs runs properly should be available soon. I'll try to produce a report where fuzzers run in the latest experiment replace results from 2020-03-19

@jonathanmetzman Thanks for the clarification! Since the fuzzers are updated regularly, do you think it would be helpful to tag the reports with particular commits? (EDIT: Nevermind, #94 addresses this)

yifengchen-cc pushed a commit to yifengchen-cc/fuzzbench that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants