Skip to content

Commit

Permalink
gapis/resolve: Fix commands vanishing on edit.
Browse files Browse the repository at this point in the history
The caller private field was not being propagated, resulting the command being grouped under the 0'th command.

Fixes: #1265
  • Loading branch information
ben-clayton committed Oct 30, 2017
1 parent 1253fdc commit 01963d2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions gapis/resolve/set.go
Expand Up @@ -137,6 +137,11 @@ func change(ctx context.Context, p path.Node, val interface{}) (path.Node, error
if len(cmd.Extras().All()) == 0 {
cmd.Extras().Add(oldCmd.Extras().All()...)
}

// Propagate caller (not exposed to client)
cmd.SetCaller(oldCmd.Caller())

// Replace the command
cmds[cmdIdx] = cmd

// Store the new command list
Expand Down

0 comments on commit 01963d2

Please sign in to comment.