Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If I open a trace, modify a shader, perform a new trace, the shader list does not update. #1195

Closed
AWoloszyn opened this issue Oct 13, 2017 · 3 comments
Closed

If I open a trace, modify a shader, perform a new trace, the shader list does not update. #1195

AWoloszyn opened this issue Oct 13, 2017 · 3 comments
Labels
bug GAPIC P2 triaged

Comments

@AWoloszyn
Copy link
Contributor

This was specifically for a Vulkan trace.
The shader list does not seem to update ever again, nor am I able to push new shader modifications.
@pmuetschard pmuetschard added this to the V1.0 milestone Oct 16, 2017
@pmuetschard
Copy link
Member

Did you happen to have a "RenderPass" node selected in the command tree?

I was unable to repro this with the steps from the title, however, I have noticed that the indices in the tree nodes are strange and that if you select the render pass node, the textures/shader view is disabled.

@pmuetschard
Copy link
Member

Filed #1214, in case they are not the same, though I suspect this is because of #1214.

@pmuetschard
Copy link
Member

Tried a few more times to reproduce this and could not do so. Closing for now as discussed with @AWoloszyn. Please reopen with more detailed repro steps if you can reproduce, thanks!

pmuetschard added a commit to pmuetschard/gapid that referenced this issue Nov 3, 2017
@pmuetschard
Fixes the "hanging shader view" bug.
db844ad 
When selecting a command at a point in the trace where all shaders have
been created, then opening/capturing another trace, will cause the shader
view to stop updating itself, unless a command is selected in the (new)
trace before all shaders were created.

Fixes google#1195
Fixes google#1309
pmuetschard added a commit that referenced this issue Nov 3, 2017
@pmuetschard
Fixes the "hanging shader view" bug.
a8d6031 
When selecting a command at a point in the trace where all shaders have
been created, then opening/capturing another trace, will cause the shader
view to stop updating itself, unless a command is selected in the (new)
trace before all shaders were created.

Fixes #1195
Fixes #1309
purvisa-at-google-com added a commit that referenced this issue Sep 29, 2022
@purvisa-at-google-com
Invert gapit frame boundary flag for sensible default value (#1195)
8829e2d 
* Invert gapit frame boundary flag for sensible default value

* Change help message

* fix presubmit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GAPIC P2 triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AWoloszyn @ben-clayton @pmuetschard