Added the spy_disabled annotation to slices. #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to avoid creation/copying of any slices that are not needed during the trace. This should reduce memory pressure as we no longer need to keep shadow memory around during the trace as long as we know how to re-create it for mid-execution capture.
ben-clayton
reviewed
Sep 21, 2017
| @@ -237,7 +235,7 @@ inline void CallObserver::write(const Slice<T>& dst, uint64_t index, | |||
| template <typename T> | |||
| inline Slice<T> CallObserver::copy(const Slice<T>& dst, const Slice<T>& src) { | |||
| read(src); | |||
| if (isActive() && !shouldObserve( | |||
| if (!shouldObserve( | |||
ben-clayton
approved these changes
Sep 21, 2017
Qining
approved these changes
Sep 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to avoid creation/copying of any slices that
are not needed during the trace. This should reduce memory pressure
as we no longer need to keep shadow memory around during the trace
as long as we know how to re-create it for mid-execution capture.