Add stale unknown state to grid. #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously any task that was added to the grid, but yet to have started would have no status associated and would get labeled as Stale/Failed. This caused it to look similar to a failure case. Instead it is now labeled as Stale/Unknown as it is not in progress yet, but it has been scheduled thus the status is not yet known. It will show up in the grid as grey instead of red. This also fixes a bug where the template lookups for target and host devices had missing braces, causing those templates to fail to match.
baldwinn860
requested review from
ben-clayton and
pmuetschard
and removed request for
ben-clayton and
pmuetschard
pmuetschard
approved these changes
Oct 11, 2017
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
This occurs in Adreno devices that restrict permission for the gpu counter sysfs node. Makes sure that the device shows up in the list and that error is printed instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any task that was added to the grid, but yet to have started
would have no status associated and would get labeled as Stale/Failed.
This caused it to look similar to a failure case. Instead it is now
labeled as Stale/Unknown as it is not in progress yet, but it has been
scheduled thus the status is not yet known. It will show up in the grid
as grey instead of red.
This also fixes a bug where the template lookups for target and host
devices had missing braces, causing those templates to fail to match.