Fix monitor/scheduler race condition. #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race condition that caused the scheduler to update robot tasks with incomplete information. Managers would monitor for changes inside a goroutine that would compete with the update logic of the data owner. All initial data would be read in at once, but still in another thread, which caused the scheduler to update without full knowledge of entity state, this would cause extraneous tasks to get spawned every time robot was restarted. The fix is to initialize the owner's data with a non monitoring search in the main thread before spawning goroutines to continue monitoring updates. This ensures we have the complete initial information prior to the first update.
ben-clayton
reviewed
Oct 18, 2017
| if managers.Job != nil { | ||
| crash.Go(func() { managers.Job.SearchDevices(ctx, all, owner.updateDevice) }) | ||
| crash.Go(func() { managers.Job.SearchWorkers(ctx, all, owner.updateWorker) }) | ||
| if err := managers.Job.SearchDevices(ctx, initial, owner.updateDevice); err != nil { |
There was a problem hiding this comment.
I'm a little upset that I can't find a way to refactor this into something more compact without resorting to reflection. :(
There was a problem hiding this comment.
Yeah, me too, I had written like three different solutions but this was by far the most succinct, all the rest kind of exploded into lots of code changes.
ben-clayton
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition that caused the scheduler to update robot
tasks with incomplete information. Managers would monitor for changes
inside a goroutine that would compete with the update logic of the data
owner. All initial data would be read in at once, but still in another
thread, which caused the scheduler to update without full knowledge of
entity state, this would cause extraneous tasks to get spawned every
time robot was restarted.
The fix is to initialize the owner's data with a non monitoring search
in the main thread before spawning goroutines to continue monitoring
updates. This ensures we have the complete initial information prior to
the first update. The other changes ensure that the monitoring updates
do not append extraneous entries.